Skip to content

[doc website] Update the search experience #997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 23, 2019
Merged

[doc website] Update the search experience #997

merged 2 commits into from
Apr 23, 2019

Conversation

s-pace
Copy link
Contributor

@s-pace s-pace commented Apr 23, 2019 •
edited
Loading

👋 team,

TL;DR: Enhance the search experience as https://pipenv.readthedocs.io/en/latest/

This PR:

  • Enables async way of loading assets. It will avoid any perf issue.
  • Add the search to every pages.

Let me know if you need anything

@dbader
Copy link
Member

dbader commented Apr 23, 2019

Cheers @s-pace, works like a charm :) LGTM

@dbader dbader merged commit b4da9ce into realpython:master Apr 23, 2019
@dojutsu-user dojutsu-user mentioned this pull request May 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s-pace @dbader