api: add logging #41
Merged
api: add logging #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegodelemos
force-pushed
the
improve-logging
branch
4 times, most recently
from
8016efe
to
1e5324a
Compare
tiborsimko
reviewed
May 12, 2017
docs/restapi.rst
Outdated
| POST /jobs | ||
| ---------- | ||
| Create Jobs | ||
| ----------- |
There was a problem hiding this comment.
Create jobs here and elsewhere; the second word is lowercase.
tiborsimko
reviewed
May 12, 2017
reana_job_controller/app.py
Outdated
|
|
||
| .. http:get:: /jobs/<job_id> | ||
|
|
||
| Returns a JSON list with all the jobs. | ||
| Returns the Job object indentified by `job_id`. |
tiborsimko
reviewed
May 12, 2017
reana_job_controller/app.py
Outdated
| @@ -247,16 +286,52 @@ def get_job(job_id): | |||
| } | |||
|
|
|||
| :resheader Content-Type: application/json | |||
| :statuscode 200: no error - the list has been returned. | |||
| :statuscode 200: no error - the Job has been returned. | |||
There was a problem hiding this comment.
"no error" sounds negative, rather formulate positive things positively 😄 for example "200 OK - the jo has been returned"
diegodelemos
force-pushed
the
improve-logging
branch
from
1e5324a
to
aa95ac5
Compare
|
Once #40 gets merged I will rebase on top of it and adapt the new endpoint 🙃 |
tiborsimko
reviewed
May 15, 2017
reana_job_controller/app.py
Outdated
| @@ -232,7 +271,7 @@ def get_job(job_id): | |||
|
|
|||
| { | |||
| "job": { | |||
| "cmd": "sleep 1000", | |||
| "cmd": "echo helloworld", | |||
tiborsimko
reviewed
May 15, 2017
reana_job_controller/app.py
Outdated
| @@ -136,7 +120,7 @@ def create_job(): | |||
|
|
|||
| { | |||
| "docker-img": "busybox", | |||
| "cmd": "sleep 1000", | |||
| "cmd": "echo helloworld", | |||
Signed-off-by: Diego Rodriguez <diego.rodriguez@cern.ch>
diegodelemos
force-pushed
the
improve-logging
branch
2 times, most recently
from
a6a9378
to
792aab5
Compare
diegodelemos
force-pushed
the
improve-logging
branch
3 times, most recently
from
d54ed28
to
0b99860
Compare
* Refactors JOB_DB management towards DB switch. Signed-off-by: Diego Rodriguez <diego.rodriguez@cern.ch>
|
Tested creating cluster from scratch. ✅ (along with reanahub/reana-workflow-engine-yadage#26) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Diego Rodriguez diego.rodriguez@cern.ch