wf-details: do not change chosen log tab automatically #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giuseppe-steduto
changed the title
Changes the JobLogs component so that instead of constantly updating the logs to show the last "failed" or "running" step, the step is changed only on page load, or when the list of logs change from being empty to having at least one entry. Closes reanahub#351.
giuseppe-steduto
force-pushed
the
no-automatic-log-refresh
branch
from
80a3674
to
aece0a9
Compare
tiborsimko
reviewed
Sep 26, 2023
| const [selectedStep, setSelectedStep] = useState(lastStepID); | ||
|
|
||
| useEffect(() => { | ||
| // Only update the shown step logs if there was no log displayed before |
There was a problem hiding this comment.
Works nicely. Sometimes I'm seeing job logs but the job button status still says "created". Perhaps this could be improved as part of #354? (Anyway, for real physics analysis payloads, when jobs may be running for hours, this time difference shouldn't really appear in the Web UI.)
tiborsimko
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the JobLogs component so that instead of constantly updating the
logs to show the last "failed" or "running" step, the step is changed
only on page load, or when the list of logs change from being empty to
having at least one entry.
Closes #351.