consumer: addition of JobStatusConsumer class #106
Conversation
| @@ -1,7 +1,7 @@ | |||
| # -*- coding: utf-8 -*- | |||
| # | |||
| # This file is part of REANA. | |||
| # Copyright (C) 2018 CERN. | |||
| # Copyright (C) 2017, 2018 CERN. | |||
| @@ -20,39 +20,23 @@ | |||
| # granted to it by virtue of its status as an Intergovernmental Organization or | |||
| # submit itself to any jurisdiction. | |||
|
|
|||
| """REANA Workflow Controller MQ Consumer.""" | |||
dinosk
force-pushed
the
job-status-consumer
branch
2 times, most recently
from
129a451
to
6af9bd9
Compare
Dockerfile
Outdated
| @@ -24,8 +24,6 @@ RUN apt-get update && \ | |||
| apt-get install -y vim-tiny && \ | |||
| pip install --upgrade pip | |||
|
|
|||
| RUN pip install -e git://github.com/reanahub/reana-commons.git@master#egg=reana-commons | |||
There was a problem hiding this comment.
Missing reana-commons. You can add it just before COPY . /code, also reana-workflow-commons could be moved before.
There was a problem hiding this comment.
Adding it, in reanahub/reana-workflow-engine-cwl#46 @tiborsimko suggested adding it after the COPY . /code, I am not sure if this specific order affects the rebuilding though.
There was a problem hiding this comment.
Because until we don't release reana-commons and reana-workflow-commons in PyPI we will have to rebuild the image with no cache if we change any of the repos since the docker builder will take it as cached. You can move them after and once we release on PyPI we remove the lines, I just made the comment because it is pulling from Github the two repos and installing them every time I rebuild, therefore slowing down the rebuild.
Lets follow @tiborsimko advise then:
I would propose the safest order like:
pypi requirements builder all to cache
COPY . /code
pip r-commons r-w-commons
pip install .
There was a problem hiding this comment.
I was referring to the order 1. COPY 2. pip install -e git://... if it affected the docker image building, the rest is of course obvious. The order is already as described
dinosk
force-pushed
the
job-status-consumer
branch
5 times, most recently
from
b7f4d41
to
08ecf72
Compare
* ADD JobStatusConsumer class, which inherits from the base Consumer class in reana-workflow-commons and sets it to consumer from the jobs-status queue. Signed-off-by: Dinos Kousidis <dinos.kousidis@cern.ch>
dinosk
force-pushed
the
job-status-consumer
branch
from
08ecf72
to
b77bc13
Compare
| @@ -23,7 +23,7 @@ FROM python:3.6 | |||
| RUN apt-get update && \ | |||
| apt-get install -y vim-tiny && \ | |||
| pip install --upgrade pip | |||
|
|
|||
| RUN pip install -e git://github.com/reanahub/reana-workflow-commons.git@master#egg=reana-workflow-commons | |||
There was a problem hiding this comment.
The 2 pip install from github had to be moved here, before the installation of requirements-builder, as reana-commons and reana-workflow-commons need to be preset in the setup.py, and it fails otherwise.
base Consumer class in reana-workflow-commons and sets
it to consumer from the jobs-status queue.
Depends on reanahub/reana-workflow-commons#2
Addresses #103
Signed-off-by: Dinos Kousidis dinos.kousidis@cern.ch