Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitlab: worfklows started from GitLab using yadage failing #235

Closed
diegodelemos opened this issue Jan 8, 2020 · 0 comments · Fixed by reanahub/reana-workflow-engine-yadage#137 or reanahub/reana-workflow-controller#283
Closed

gitlab: worfklows started from GitLab using yadage failing #235

diegodelemos opened this issue Jan 8, 2020 · 0 comments · Fixed by reanahub/reana-workflow-engine-yadage#137 or reanahub/reana-workflow-controller#283
Assignees
@mvidalgarcia @diegodelemos
Labels
integration/gitlab type/bug

Comments

@diegodelemos
Copy link
Member

After integrating a yadage workflow on GitLab, I get:

$ # new commit to "REANA example - ATLAS RECAST" on GitLab
$ reana-client list
NAME                           RUN_NUMBER   CREATED               STATUS
REANA example - ATLAS RECAST   1            2020-01-08T17:04:10   failed
$ reana-client logs -w "REANA example - ATLAS RECAST"
WORKFLOW ENGINE LOGS
workflow failed: local variable 'workflow_kwargs' referenced before assignment
@diegodelemos diegodelemos self-assigned this Jan 14, 2020
diegodelemos pushed a commit to diegodelemos/reana-workflow-controller that referenced this issue Jan 16, 2020
workflow_run_manager: pass workflow file if exists
e64906a 
* There will be cases (i.e. integration with Git providers) in
  which there won't be a workflow specification stored in the
  database. This only happens when submission comes from a REANA
  client. So in this cases, by knowing the path of the workflow
  file, the workflow engines can load with their specific libraries
  the workflow files (which we will optimistically assume are there
  if not, workflow engine should fail saying there is no workflow
  to be processed) (closes reanahub/reana#235).
diegodelemos pushed a commit to diegodelemos/reana-workflow-engine-yadage that referenced this issue Jan 16, 2020
cli: accept workflow file location
5a62ea2 
* If there is no workflow specification provided to the workflow
  engine, a new parameter can be passed. This is the relative
  path to the workflow file. This is needed for the case of running
  a workflow triggered by a Git provider, i.e. on commit to master,
  so we expect the analysis code to be present in the workflow
  workspace and, hence, we can load it (closes reanahub/reana#235).
This was referenced Jan 16, 2020
Merged
Merged
@mvidalgarcia mvidalgarcia self-assigned this Jan 27, 2020
mvidalgarcia pushed a commit to diegodelemos/reana-workflow-controller that referenced this issue Jan 28, 2020
@mvidalgarcia
workflow_run_manager: pass workflow file if exists
3ba57b6 
* There will be cases (i.e. integration with Git providers) in
  which there won't be a workflow specification stored in the
  database. This only happens when submission comes from a REANA
  client. So in this cases, by knowing the path of the workflow
  file, the workflow engines can load with their specific libraries
  the workflow files (which we will optimistically assume are there
  if not, workflow engine should fail saying there is no workflow
  to be processed) (closes reanahub/reana#235).
diegodelemos pushed a commit to diegodelemos/reana-workflow-controller that referenced this issue Jan 28, 2020
workflow_run_manager: pass workflow file if exists
8a693ec 
* There will be cases (i.e. integration with Git providers) in
  which there won't be a workflow specification stored in the
  database. This only happens when submission doesn't come from a
  REANA client. So in this cases, by knowing the path of the
  workflow file, the workflow engines can load with their specific
  libraries the workflow files (which we will optimistically
  assume are there if not, workflow engine should fail saying
  there is no workflow to be processed)
  (closes reanahub/reana#235).
diegodelemos pushed a commit to diegodelemos/reana-workflow-controller that referenced this issue Jan 28, 2020
workflow_run_manager: pass workflow file if exists
82e18bd 
* There will be cases (i.e. integration with Git providers) in
  which there won't be a workflow specification stored in the
  database. This only happens when submission doesn't come from a
  REANA client. So in this cases, by knowing the path of the
  workflow file, the workflow engines can load with their specific
  libraries the workflow files (which we will optimistically
  assume are there if not, workflow engine should fail saying
  there is no workflow to be processed)
  (closes reanahub/reana#235).
@diegodelemos diegodelemos mentioned this issue Jan 29, 2020
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mvidalgarcia mvidalgarcia

@diegodelemos diegodelemos

Labels
integration/gitlab type/bug
Projects
None yet
Milestone
No milestone
2 participants
@mvidalgarcia @diegodelemos