helm: add option to split load by node affinity #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegodelemos
force-pushed
the
node-affinity
branch
from
a2b509e
to
f15fb6e
Compare
diegodelemos
force-pushed
the
node-affinity
branch
2 times, most recently
from
8f8d980
to
a6e4f55
Compare
tiborsimko
reviewed
Jul 22, 2020
diegodelemos
force-pushed
the
node-affinity
branch
from
a6e4f55
to
309a9ff
Compare
tiborsimko
reviewed
Jul 23, 2020
diegodelemos
commented
Jul 23, 2020
diegodelemos
force-pushed
the
node-affinity
branch
from
309a9ff
to
bac4695
Compare
tiborsimko
approved these changes
Jul 24, 2020
tiborsimko
reviewed
Jul 24, 2020
* Uses explicit nodeSelector on infrastructure pods since the pods will be deployed to a namespace selected by the user (through `helm install --namespace foo`) or to the default namespace. Therefore we cannot modify the user namespace and specify a nodeSelector at namespace level. For runtime pods, since we create the namespace, we can specify a nodeSelector for the whole namespace.
diegodelemos
force-pushed
the
node-affinity
branch
from
bac4695
to
65bb5e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.