-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: move to docs.reana.io enrich README #354
docs: move to docs.reana.io enrich README #354
Conversation
diegodelemos
commented
Jul 27, 2020
•
edited
Loading
edited
- Closes docs: remove reana.readthedocs.io Sphinx docs and move to docs.reana.io #355.
6f778fc
to
81187e2
Compare
81187e2
to
364329b
Compare
b8853bd
to
d34b3a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In pytest.ini, there's --ignore=docs
, can we delete this now?
README.rst
Outdated
@@ -1,3 +1,7 @@ | |||
.. image:: images/logo-reana.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logo seems huge to me. WDYT about setting some width or scale?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, I've tried several combinations and nothing seems to be applied (I've used the GitHub web editor on README.rst
to test the preview). I guess we have to resize the image manually?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mmh weird, I've tried and I can reproduce what you say... perhaps we can embed html <img>
somehow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have impactful software, so big logo 😉 Anyway, check e.g. Luigi logo which is also pretty big, I think it is OK for MVP if scaling directives are being ignored...
d34b3a9
to
b34524b
Compare
0f8c0c6
to
76fb58a
Compare
57002eb
to
aae9946
Compare
aae9946
to
9abd6ff
Compare