Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: move to docs.reana.io enrich README #354

Merged
merged 1 commit into from
Aug 7, 2020

Conversation

diegodelemos
Copy link
Member

@diegodelemos diegodelemos commented Jul 27, 2020

@diegodelemos diegodelemos self-assigned this Jul 27, 2020
@diegodelemos diegodelemos removed their assignment Jul 27, 2020
@diegodelemos diegodelemos force-pushed the 335-restructuring-docs branch 2 times, most recently from b8853bd to d34b3a9 Compare July 28, 2020 08:17
@diegodelemos diegodelemos marked this pull request as ready for review July 28, 2020 08:17
Copy link
Member

@mvidalgarcia mvidalgarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In pytest.ini, there's --ignore=docs, can we delete this now?

CONTRIBUTING.rst Show resolved Hide resolved
README.rst Outdated
@@ -1,3 +1,7 @@
.. image:: images/logo-reana.png
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logo seems huge to me. WDYT about setting some width or scale?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, I've tried several combinations and nothing seems to be applied (I've used the GitHub web editor on README.rst to test the preview). I guess we have to resize the image manually?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmh weird, I've tried and I can reproduce what you say... perhaps we can embed html <img> somehow?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have impactful software, so big logo 😉 Anyway, check e.g. Luigi logo which is also pretty big, I think it is OK for MVP if scaling directives are being ignored...

README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
MANIFEST.in Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
@diegodelemos diegodelemos force-pushed the 335-restructuring-docs branch 2 times, most recently from 0f8c0c6 to 76fb58a Compare August 7, 2020 13:49
docs/index.rst Outdated Show resolved Hide resolved
@diegodelemos diegodelemos force-pushed the 335-restructuring-docs branch 2 times, most recently from 57002eb to aae9946 Compare August 7, 2020 14:14
@tiborsimko tiborsimko merged commit 9abd6ff into reanahub:master Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: remove reana.readthedocs.io Sphinx docs and move to docs.reana.io
3 participants