Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: don't autodiscover version when passed as arg #379

Merged
merged 1 commit into from
Sep 15, 2020
Merged

cli: don't autodiscover version when passed as arg #379

merged 1 commit into from
Sep 15, 2020

Conversation

diegodelemos
Copy link
Member

tiborsimko
tiborsimko requested changes Aug 14, 2020
View reviewed changes
Copy link
Member

@tiborsimko tiborsimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change works for the issue at hand, but it also actually breaks the regular use case:

$ reana-dev git-create-release-commit -c r-server
[2020-08-14T12:16:56] reana-server: Version cannot be autodiscovered from source files.

where the master version works fine..

@diegodelemos diegodelemos force-pushed the 378-use-passed-version branch 2 times, most recently from d1ec672 to b7c8082 Compare September 7, 2020 07:06
@diegodelemos
Copy link
Member Author

Should be ready to go now.

@tiborsimko tiborsimko merged commit 119aef2 into reanahub:master Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiborsimko tiborsimko tiborsimko approved these changes

@audrium audrium audrium approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

git-create-release-commit: trying version autodiscovery even when -v is passed
3 participants
@diegodelemos @tiborsimko @audrium