cli: add git-upgrade-requirements

[mdonadoni]

Closes #741

[codecov]

Codecov Report

Merging #743 (d4db226) into master (61fdde9) will increase coverage by 0.06%.
The diff coverage is 21.91%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #743      +/-   ##
==========================================
+ Coverage   18.87%   18.93%   +0.06%     
==========================================
  Files          26       26              
  Lines        2199     2271      +72     
==========================================
+ Hits          415      430      +15     
- Misses       1784     1841      +57     

Files	Coverage Δ
reana/config.py	100.00% <100.00%> (ø)
reana/reana_dev/utils.py	38.30% <4.34%> (-2.14%)	⬇️
reana/reana_dev/git.py	29.50% <23.91%> (-0.65%)	⬇️

[mdonadoni]

What should we do regarding feature branch creation/management? Currently git-upgrade-shared-modules and git-upgrade-requirements need to be run in a repository where the current branch is a feature branch, and they will fail if the branch is master.

Instead git-create-release-commit creates a new branch release-1.2.3, but this command is usually executed as last when making a new release: first the shared modules are updated, then all the dependencies in requirements.txt are updated (if needed), and finally the release commit is created.

Should we change git-upgrade-shared-modules/git-upgrade-requirements to also create a new feature branch? Which name should they use? Or should we create a new git-create-release-branch command?

[giuseppe-steduto]

Should we change git-upgrade-shared-modules/git-upgrade-requirements to also create a new feature branch?

I'd say that these commands would mainly be run:

• either during the normal development process, case in which we would very likely already be on a feature branch
• or during the release process, case in which it would make sense to use the release-1.2.3 branch.

Maybe a nice idea could be adding a flag to git-create-release-commit (to also call the git-upgrade-requirements command), or viceversa, add a flag to the upgrade requirements command (to also create the release commit and branch).

What do you think?

/cc @tiborsimko

[giuseppe-steduto]

Looks good!

[mdonadoni]

Maybe a nice idea could be adding a flag to git-create-release-commit (to also call the git-upgrade-requirements command), or viceversa, add a flag to the upgrade requirements command (to also create the release commit and branch).

What do you think?

I tried this approach, but it felt like those commands were getting quite complicated. In the end I have created a new git-create-release-branch command, and we could maybe group all the release-related commands in an (yet) another git-prepare-release command, that invokes all the others in the correct order?

[giuseppe-steduto]

we could maybe group all the release-related commands in an (yet) another git-prepare-release command, that invokes all the others in the correct order?

Sounds good to me! Do you want to address this here or in another issue?

[mdonadoni]

Sounds good to me! Do you want to address this here or in another issue?

Let's do it in another issue/PR, this one is already quite big!