-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm: add demo repositories info for launcher page in UI #746
helm: add demo repositories info for launcher page in UI #746
Conversation
a67e31b
to
9d0da26
Compare
Should we give admins the possibility to also specify the REANA specification file for the example to be launched? Personally I think it might feel a bit like "overloading". |
{{- range .Values.ui_launcher_repositories | default (list) }} | ||
- name: {{ .name | quote }} | ||
url: {{ .url | quote }} | ||
image_url: {{ .image_url | quote }} | ||
{{- end }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(minor) You can probably use toYaml
to avoid all of this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't know about it, nice! The "problem" with toYaml
however is that as far as I have understood and tried, everything has to be already properly indented and quoted in the values file, so I guess it gives less flexibility to the admins. Since this whole range
thing is not too big and gives the details about the properties in the list, I think we can keep it this way. Do you agree?
To be honest, I think that would be a nice addition! I think the ideal would be to make this field optional, defaulting to |
9d0da26
to
ebafc8a
Compare
ebafc8a
to
69e7211
Compare
69e7211
to
8f0ae5a
Compare
8f0ae5a
to
97c0566
Compare
Closes reanahub/reana-ui#323.