Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: add demo repositories info for launcher page in UI #746

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

giuseppe-steduto
Copy link
Member

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #746 (97c0566) into master (9dd672d) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #746   +/-   ##
=======================================
  Coverage   18.87%   18.87%           
=======================================
  Files          26       26           
  Lines        2199     2199           
=======================================
  Hits          415      415           
  Misses       1784     1784           

@giuseppe-steduto giuseppe-steduto force-pushed the customize-launcher-page branch 2 times, most recently from a67e31b to 9d0da26 Compare September 20, 2023 09:16
@giuseppe-steduto
Copy link
Member Author

Should we give admins the possibility to also specify the REANA specification file for the example to be launched? Personally I think it might feel a bit like "overloading".

helm/reana/values.yaml Outdated Show resolved Hide resolved
CHANGES.rst Outdated Show resolved Hide resolved
helm/reana/README.md Outdated Show resolved Hide resolved
Comment on lines 38 to 44
{{- range .Values.ui_launcher_repositories | default (list) }}
- name: {{ .name | quote }}
url: {{ .url | quote }}
image_url: {{ .image_url | quote }}
{{- end }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(minor) You can probably use toYaml to avoid all of this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know about it, nice! The "problem" with toYaml however is that as far as I have understood and tried, everything has to be already properly indented and quoted in the values file, so I guess it gives less flexibility to the admins. Since this whole range thing is not too big and gives the details about the properties in the list, I think we can keep it this way. Do you agree?

@mdonadoni
Copy link
Member

Should we give admins the possibility to also specify the REANA specification file for the example to be launched?
Personally I think it might feel a bit like "overloading".

To be honest, I think that would be a nice addition! I think the ideal would be to make this field optional, defaulting to reana.yaml. We could even go as far as letting admins also customise the name of the launched workflows, but this is really minor compared to customising the REANA specification file.

helm/reana/values.yaml Outdated Show resolved Hide resolved
helm/reana/README.md Outdated Show resolved Hide resolved
helm/reana/templates/reana-config.yaml Outdated Show resolved Hide resolved
helm/reana/templates/reana-config.yaml Outdated Show resolved Hide resolved
CHANGES.rst Outdated Show resolved Hide resolved
helm/reana/README.md Outdated Show resolved Hide resolved
@mdonadoni mdonadoni merged commit 97c0566 into reanahub:master Sep 27, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

launch: make launcher homepage customizable
2 participants