Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): add value to customise env vars of job controller and workflow engines (#781) #781

Merged

Conversation

mdonadoni
Copy link
Member

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 18.63%. Comparing base (aba8ac2) to head (634691f).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #781   +/-   ##
=======================================
  Coverage   18.63%   18.63%           
=======================================
  Files          26       26           
  Lines        2345     2345           
=======================================
  Hits          437      437           
  Misses       1908     1908           

Copy link
Member

@giuseppe-steduto giuseppe-steduto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but a rebase is needed!

@mdonadoni mdonadoni force-pushed the env-vars-workflow-engine-job-controller branch from c8d24c5 to 634691f Compare February 28, 2024 13:36
@mdonadoni mdonadoni merged commit 634691f into reanahub:master Feb 28, 2024
15 checks passed
@mdonadoni mdonadoni deleted the env-vars-workflow-engine-job-controller branch February 28, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants