fix(helm): use ingressClassName instead of deprecated annotation (#794) #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #794 +/- ##
=======================================
Coverage 18.15% 18.15%
=======================================
Files 26 26
Lines 2478 2478
=======================================
Hits 450 450
Misses 2028 2028 |
|
Tested and working on DEV after removing the |
tiborsimko
reviewed
Apr 15, 2024
helm/reana/README.md
Outdated
| | `ingress.annotations.traefik.ingress.kubernetes.io/router.entrypoints` | Entrypoints allowed by the ingress controller | "web,websecure" | | ||
| | `ingress.enabled` | Create an ingress resource to access the REANA instance from outside the cluster | true | | ||
| | `ingress.extra` | An array of extra ingress resources. They can be configured in the same way as the default ingress, with the addition of `ingress.extra[].name`. | [] | | ||
| | `ingress.ingress_class_name` | Name of the Ingress class to use. Set to `null` to use the cluster's default class. | null | |
There was a problem hiding this comment.
Perhaps rename the help message's second phrase a bit, to say: "Name of the Ingress class to use. Default value (null) will use the cluster's default Ingress class."
mdonadoni
force-pushed
the
ingress-class-name
branch
from
d535eb0
to
b4f4633
Compare
tiborsimko
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #742