Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): cover prefer-lowest stability #1055

Merged
merged 4 commits into from
Jun 24, 2023
Merged

chore(tests): cover prefer-lowest stability #1055

merged 4 commits into from
Jun 24, 2023

Conversation

mfn
Copy link
Collaborator

@mfn mfn commented Jun 24, 2023

Summary

In order to make this work:

  • for PHP 8.2, the lowest Laravel 9 version supported is 9.33 due to Carbon
    However, this is only taken care of in the github action runs and not via the projects composer.json
  • laragraph/utils and webonyx/graphql-php needed a slight bump due to bug fixes required to make our test suite work

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Misc. change (internal, infrastructure, maintenance, etc.)

Checklist:

  • Existing tests have been adapted and/or new tests have been added
  • Add a CHANGELOG.md entry
  • Update the README.md
  • Code style has been fixed via composer fix-style

@mfn mfn self-assigned this Jun 24, 2023
@mfn mfn marked this pull request as ready for review June 24, 2023 20:00
@mfn mfn merged commit 8456b1a into master Jun 24, 2023
@mfn mfn deleted the mfn-gha-test-lowest branch June 24, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant