Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOTFIX] Prepare 5.1.1 release and revert "Add support for validation in field arguments" #628

Merged
merged 3 commits into from
Apr 23, 2020
Merged

[HOTFIX] Prepare 5.1.1 release and revert "Add support for validation in field arguments" #628

merged 3 commits into from
Apr 23, 2020

Conversation

mfn
Copy link
Collaborator

@mfn mfn commented Apr 23, 2020

Summary

This reverts #608 due to breaking changes reported via #627

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Misc. change (internal, infrastructure, maintenance, etc.)

Checklist

  • Existing tests have been adapted and/or new tests have been added
  • Add a CHANGELOG.md entry
  • Update the README.md
  • Code style has been fixed via composer fix-style

@mfn mfn self-assigned this Apr 23, 2020
@mfn mfn marked this pull request as ready for review April 23, 2020 09:27
@mfn
Copy link
Collaborator Author

mfn commented Apr 23, 2020

Also running in a private project to verify nothing breaks 🤞

@mfn
Copy link
Collaborator Author

mfn commented Apr 23, 2020

Looks good :)

@mfn mfn merged commit c3b4a38 into master Apr 23, 2020
@mfn mfn deleted the mp-revert branch September 1, 2020 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mfn mfn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mfn