Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat - shortcuts, workspace support and open current block #9

Merged
merged 19 commits into from
Nov 16, 2023
Merged

Feat - shortcuts, workspace support and open current block #9

merged 19 commits into from
Nov 16, 2023

Conversation

e-zz
Copy link
Contributor

@e-zz e-zz commented Nov 16, 2023

Thanks to the great potential of the plugin, this PR brings you what comes really handy if you frequently switch between VS Code and Logseq.

  • Open the current block (implemented by opening the page to certain line)
  • Open in the same VS Code instance (under the graph folder or workspace)
  • Support VS Codium
  • Shortcuts and customization

I have updated readme to explain these changes.

PS: This PR is based on #8

e-zz added 19 commits May 9, 2023 01:09
fix(api): "open current page" fails to work
97e9d7f
feat: add shortcuts
48bea91
feat: support VS Codium
b1ee441
fix typos
debb4e7
update: README.md
d8b7729
chore: add build option "watch"
3cebd58
wip: support jump to current line
7ab6f5a
update readme
1c3a39d
Rewrite README
c25e206
[wip] reuse vscode winsow
9e7a887
fix: wrong line number due to property block
43586c7
fix: open block in the waterfall view of journals
6575d60
fix: upstream change in api
ae3969c
fix: opening wrong page for blocks in sidebar
a6b47ac
refa
a5decd1
feat: open graph as a VS Code workspace
f581bea
update menu options
38dee25
vscode url api change
3cc13a4
refactor:
4742f4a 
- remove redundant options;
- rewrite openCurrentLine
- unify function naming style

enchance
- add `row_num` parameter (default 999) to put cursor at the end

update(readme)
rebornix
rebornix approved these changes Nov 16, 2023
View reviewed changes
Copy link
Owner

@rebornix rebornix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, thank you for the contribution!

@rebornix rebornix merged commit 9d4b4bc into rebornix:main Nov 16, 2023
This was referenced Nov 16, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebornix rebornix rebornix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@e-zz @rebornix