Fix issue with unsafe flags when using SwiftPM #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #615, -weak_framework SwiftUI was added as an unsafe compiler flag to the Swift package and Xcode project. This fixed an issue where you could not use Parchment on platforms that did not support SwiftUI. It turned out that this causes another issue where users cannot install Parchment using SwiftPM (reproducible by creating a new Xcode project with the SwiftUI template). Removing this will probably bring back the other issue, but most people have started updating to iOS versions that support SwiftUI now. People still using older iOS version would have to target version 3.2.0, but that is probably fine as the majority of new features are likely to be SwiftUI improvements anyway.
|
Maybe you can consider split SwiftUI and UIKit into 2 swift package library~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #615, -weak_framework SwiftUI was added as an unsafe compiler flag to the Swift package and Xcode project. This fixed an issue where you could not use Parchment on platforms that did not support SwiftUI. It turned out that this causes another issue where users cannot install Parchment using SwiftPM (reproducible by creating a new Xcode project with the SwiftUI template).
Removing this will probably bring back the other issue, but most people have started updating to iOS versions that support SwiftUI now. People still using older iOS version would have to target version 3.2.0, but that is probably fine as the majority of new features are likely to be SwiftUI improvements anyway.