Skip to content

Conversation

aditya-bhaumik
Copy link
Member

@aditya-bhaumik aditya-bhaumik commented Aug 24, 2024

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@vivekvardhan2810
Copy link
Member

vivekvardhan2810 commented Aug 24, 2024

Added Milestones
image

Fixed: #1154

@vivekvardhan2810
Copy link
Member

@sanjay-kv, me and @aditya-bhaumik co authored and solved.

@shreyash3087
Copy link
Member

@vivekvardhan2810 @aditya-bhaumik why is it static? and what does the progress bar mean? "5/10 closed" what?

@vivekvardhan2810
Copy link
Member

vivekvardhan2810 commented Aug 24, 2024

@shreyash3087,

The progress bar means that we can know the status of that particular folder, whereas “5/10 closed” indicates that 5 out of 10 tasks, items, or stages have been completed or resolved.

And we added extra cards so that there are some 50 percent ones also all of the ones in the repo are 100

And Which was not looking good

So that's why.

@vansh-codes
Copy link
Member

@vivekvardhan2810 @aditya-bhaumik I guess writing 34/34 will work or to give more details 34/34 done would also work
There's no need for 34 closed / 34 done according to me..
What say @shreyash3087 ??

@aditya-bhaumik
Copy link
Member Author

@vansh-codes no it will not look nice

@vivekvardhan2810
Copy link
Member

vivekvardhan2810 commented Aug 24, 2024

@vansh-codes i made according to the image sanjay gave me in issue which assigned to me. So i have added

And there is no need

image

As It is mentioned total and closed

Lets say you have 40 total issues on that project and there are only 20 done till now, There will be still 20 left, from this we can understand and we know so that it will be more informative

How is that method is going to help.

@vansh-codes
Copy link
Member

okay @aditya-bhaumik @vivekvardhan2810

@aditya-bhaumik
Copy link
Member Author

aditya-bhaumik commented Aug 24, 2024

@shreyash3087 its static because all of the projects are done so all are 10/10 or 20/20 which is 100 percent and i dont think new issues will be added as for the extra cards we added them because all the cards had 100
which was not looking good

So added a 2 - 3 50 percent also

@MastanSayyad
Copy link
Member

@aditya-bhaumik @vivekvardhan2810, you both work on this together as co-authors right? I only see Vivek’s commits with code additions and @aditya-bhaumik’s three deletions of "empty space". Did you discuss the code and collaborate, with Vivek making the actual code changes? Or is this just for the badge purpose?

@aditya-bhaumik
Copy link
Member Author

Yes @MastanSayyad

@aditya-bhaumik
Copy link
Member Author

aditya-bhaumik commented Aug 25, 2024

@MastanSayyad check the issue once which was assigned to vivek once and we both already have the badge

You can just do gmeet through whatsapp with the person you are collabrating makes the work so much easier

@aditya-bhaumik
Copy link
Member Author

@MastanSayyad both of us worked on it together should not matter who made the commit

@MastanSayyad
Copy link
Member

Yeah, no worries! Was just curious as it was static.

@sanjay-kv sanjay-kv merged commit efe82ac into recodehive:main Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants