-
Notifications
You must be signed in to change notification settings - Fork 115
fixed issue#659 #681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed issue#659 #681
Conversation
@Condition00 is attempting to deploy a commit to the recode Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. The estimated time for response is 5–8 hrs. In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, a video recording, or an image of the update you made below, which helps speed up the review and assignment. If you have questions, reach out to LinkedIn. Your contributions are highly appreciated!😊 Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv. We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰 🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨ 📚Your perks for contribution to this community 👇🏻
If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes spacing and padding issues in the Floating Card Component by improving layout consistency and removing redundant text from the contributor count display.
- Updated contributor threshold from 12 to 5 for displaying the "more" count
- Removed the word "more" from the contributor count text, showing only the numeric count
- Enhanced spacing, padding, and layout properties throughout the component for better visual consistency
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
src/components/FloatingContributors/index.tsx | Updated contributor threshold and removed "more" text from count display |
src/components/FloatingContributors/FloatingContributors.css | Comprehensive spacing and layout improvements including padding, gaps, and height adjustments |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
{contributors.length > 5 && ( | ||
<div className="contributors-more"> | ||
<span>+{contributors.length - 12} more</span> | ||
<span>+{contributors.length - 5}</span> | ||
</div> | ||
)} |
Copilot
AI
Oct 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The magic number 5 is used twice without explanation. Consider extracting this to a named constant like CONTRIBUTORS_DISPLAY_THRESHOLD
to improve maintainability and make the relationship between the condition and calculation more explicit.
Copilot uses AI. Check for mistakes.
Synced data from Linked IssuesLabels:
Assignees:
Milestones:
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Description
Fixed normal spacing and removed extra "more" keyword.
Fixes # (issue)
padding and spacing issue in the Floating Card Component
Type of Change
Changes Made
Added padding gaps and spacing to the card component.
Dependencies
No new dependency.
Checklist
npm run build
and attached screenshot(s) in this PR.Fixes #659