Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#1010): fix WeakLabels when not providing rules #1011

Merged
merged 3 commits into from Jan 21, 2022

Conversation

dcfidalgo
Copy link
Contributor

@dcfidalgo dcfidalgo commented Jan 20, 2022

Closes #1010

Merge with #976

@dcfidalgo dcfidalgo added labeling type: bug Indicates an unexpected problem or unintended behavior labels Jan 20, 2022
@dcfidalgo dcfidalgo self-assigned this Jan 20, 2022
@dcfidalgo dcfidalgo added this to In progress in Release via automation Jan 20, 2022
@frascuchon
Copy link
Member

This issue affect to the latest release or since PR #976 ? In that case. Make reference to original PR or issue to avoid include as fix in next release. Thanks

@dcfidalgo
Copy link
Contributor Author

Yes, this only affects #955, they should go together in a release.

@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #1011 (d2133af) into master (9ed31df) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1011      +/-   ##
==========================================
- Coverage   95.48%   95.36%   -0.13%     
==========================================
  Files         110      110              
  Lines        4235     4248      +13     
==========================================
+ Hits         4044     4051       +7     
- Misses        191      197       +6     
Flag Coverage Δ
pytest 95.36% <100.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rubrix/labeling/text_classification/weak_labels.py 100.00% <100.00%> (ø)
src/rubrix/server/commons/static_rewrite.py 44.44% <0.00%> (-11.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ed31df...d2133af. Read the comment docs.

@frascuchon frascuchon linked an issue Jan 21, 2022 that may be closed by this pull request
Release automation moved this from In progress to Review Jan 21, 2022
@dcfidalgo dcfidalgo merged commit 176e48a into master Jan 21, 2022
Release automation moved this from Review to Done Jan 21, 2022
@dcfidalgo dcfidalgo deleted the fix/weak_labels_without_rules branch January 21, 2022 10:24
dvsrepo added a commit that referenced this pull request Jan 25, 2022
* 'master' of https://github.com/recognai/rubrix: (28 commits)
  chore(#994): simplify server start (#1014)
  refactor(#945): elasticsearch index configuration per task (#1018)
  docs(#980): Add majorityvote example to weak supervision guide (#1004)
  fix(#1015): manage emojis in Token Classification records (#1016)
  fix(#1010): fix WeakLabels when not providing rules (#1011)
  fix(Breadcrumbs): Copy text function (#1003)
  fix(statics): handle 404 errors for static files (#1006)
  refactor: Rename 'exclude_missing_annotation' argument for WeakLabels.annotation (#1005)
  docs: update video for spacy ner tutorial (#1000)
  fix(#977) Remove redirection when accessing login (#996)
  feat(#951): new uncovered_by_rules records filter (#991)
  feat(#735): add warning when agent but no prediction/annotation is provided (#987)
  fix(#800): limit number of metadata fields (#993)
  docs: improve annotate records section in web app reference (#985)
  fix(#844) Keep header layout when errors occurred in dataset view (#992)
  fix(#974): display the dropdown in the last record of the scroll (#986)
  refactor: compute common aggregations one by one (#990)
  feat(#953): add additional metrics to `LabelModel.score` method (#979)
  refactor(rules): using labeling rules management with vuex store (#878)
  feat(#955): add default for `rules` in WeakLabels (#976)
  ...
@frascuchon frascuchon removed this from Done in Release Jan 31, 2022
frascuchon pushed a commit that referenced this pull request Feb 2, 2022
* feat: load rules of dataset by default

* test: add tests

* test: fix tests

fix(#1010): fix WeakLabels when not providing rules (#1011)

* fix: bugfix when no rules but a ds is provided

* test: add test

* test: fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[WeakLabels] bug when not providing rules [WeakLabels] Load rules from dataset, when no rules are provided
2 participants