Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Search] search.max_buckets configuration could affect to search results #800

Closed
frascuchon opened this issue Dec 13, 2021 · 0 comments · Fixed by #993 or #990
Closed

[Search] search.max_buckets configuration could affect to search results #800

frascuchon opened this issue Dec 13, 2021 · 0 comments · Fixed by #993 or #990
Assignees
@frascuchon
Labels
area: server Indicates that an issue or pull request is related to the server type: bug Indicates an unexpected problem or unintended behavior
Projects
Release

Comments

@frascuchon
Copy link
Member

Some environments where elasticsearch cluster has extra search configuration (see search settings) brings search errors related to aggregation results:

Screenshot 2021-12-13 at 21 22 53

We must include optimization and limit mechanism in server to avoid this behaviour
@frascuchon frascuchon added type: bug Indicates an unexpected problem or unintended behavior area: server Indicates that an issue or pull request is related to the server labels Dec 13, 2021
@frascuchon frascuchon self-assigned this Dec 13, 2021
@frascuchon frascuchon added this to To do in Release via automation Jan 13, 2022
@frascuchon frascuchon moved this from To do to TODO Release in Release Jan 17, 2022
@frascuchon frascuchon moved this from Planified to In progress in Release Jan 17, 2022
This was referenced Jan 17, 2022
Merged
Merged
@frascuchon frascuchon linked a pull request Jan 18, 2022 that will close this issue
fix(search): compute common aggregations one by one #990
Merged
Release automation moved this from In progress to Done Jan 18, 2022
frascuchon added a commit that referenced this issue Jan 18, 2022
@frascuchon
fix(#800): limit number of metadata fields (#993)
6c743ab 
* feat(env): configurable metadata fields limit

* feat(log): limit number of (flatten) metadata fields

* test: add tests

* revert: changes

* refactor: compute metadata length including also the stored values

* fix: add missing files

* test: include some tests
frascuchon added a commit that referenced this issue Jan 19, 2022
@frascuchon
fix(#800): compute common aggregations one by one (#990)
8cf420a 
(cherry picked from commit 46f2ce2)
frascuchon added a commit that referenced this issue Jan 19, 2022
@frascuchon
fix(#800): limit number of metadata fields (#993)
bb6b76b 
* feat(env): configurable metadata fields limit

* feat(log): limit number of (flatten) metadata fields

* test: add tests

* revert: changes

* refactor: compute metadata length including also the stored values

* fix: add missing files

* test: include some tests

(cherry picked from commit 6c743ab)
@frascuchon frascuchon moved this from Done to Release Ready in Release Jan 20, 2022
@frascuchon frascuchon moved this from Release Ready to Done in Release Jan 20, 2022
@frascuchon frascuchon moved this from Done to Release Ready in Release Jan 20, 2022
@frascuchon frascuchon moved this from Release Ready to Closed in Release Jan 20, 2022
dvsrepo added a commit that referenced this issue Jan 25, 2022
@dvsrepo
Merge branch 'master' of https://github.com/recognai/rubrix
8f89dda 
* 'master' of https://github.com/recognai/rubrix: (28 commits)
  chore(#994): simplify server start (#1014)
  refactor(#945): elasticsearch index configuration per task (#1018)
  docs(#980): Add majorityvote example to weak supervision guide (#1004)
  fix(#1015): manage emojis in Token Classification records (#1016)
  fix(#1010): fix WeakLabels when not providing rules (#1011)
  fix(Breadcrumbs): Copy text function (#1003)
  fix(statics): handle 404 errors for static files (#1006)
  refactor: Rename 'exclude_missing_annotation' argument for WeakLabels.annotation (#1005)
  docs: update video for spacy ner tutorial (#1000)
  fix(#977) Remove redirection when accessing login (#996)
  feat(#951): new uncovered_by_rules records filter (#991)
  feat(#735): add warning when agent but no prediction/annotation is provided (#987)
  fix(#800): limit number of metadata fields (#993)
  docs: improve annotate records section in web app reference (#985)
  fix(#844) Keep header layout when errors occurred in dataset view (#992)
  fix(#974): display the dropdown in the last record of the scroll (#986)
  refactor: compute common aggregations one by one (#990)
  feat(#953): add additional metrics to `LabelModel.score` method (#979)
  refactor(rules): using labeling rules management with vuex store (#878)
  feat(#955): add default for `rules` in WeakLabels (#976)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frascuchon frascuchon

Labels
area: server Indicates that an issue or pull request is related to the server type: bug Indicates an unexpected problem or unintended behavior
Projects
No open projects
Release
Approved Release QA
Milestone
No milestone
1 participant
@frascuchon