Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#955): add default for rules in WeakLabels #976

Merged
merged 3 commits into from Jan 17, 2022

Conversation

dcfidalgo
Copy link
Contributor

Closes #955
This PR adds a default behavior when no rules are provided. Then the rules are loaded from the given dataset, and if no rules are found it will raise an exception.

@dcfidalgo dcfidalgo self-assigned this Jan 14, 2022
@dcfidalgo dcfidalgo added this to In progress in Release via automation Jan 14, 2022
@dcfidalgo dcfidalgo changed the title feat: add default for rules in WeakLabels feat(#955): add default for rules in WeakLabels Jan 14, 2022
@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #976 (694d1e5) into master (f4e346f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #976   +/-   ##
=======================================
  Coverage   95.50%   95.51%           
=======================================
  Files         109      109           
  Lines        4206     4212    +6     
=======================================
+ Hits         4017     4023    +6     
  Misses        189      189           
Flag Coverage Δ
pytest 95.51% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rubrix/labeling/text_classification/weak_labels.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4e346f...694d1e5. Read the comment docs.

Release automation moved this from In progress to Reviewer approved Jan 16, 2022
@dcfidalgo dcfidalgo merged commit d3cbaea into master Jan 17, 2022
Release automation moved this from Reviewer approved to Done Jan 17, 2022
@dcfidalgo dcfidalgo deleted the feat/add_default_for_rules branch January 17, 2022 09:30
dvsrepo added a commit that referenced this pull request Jan 25, 2022
* 'master' of https://github.com/recognai/rubrix: (28 commits)
  chore(#994): simplify server start (#1014)
  refactor(#945): elasticsearch index configuration per task (#1018)
  docs(#980): Add majorityvote example to weak supervision guide (#1004)
  fix(#1015): manage emojis in Token Classification records (#1016)
  fix(#1010): fix WeakLabels when not providing rules (#1011)
  fix(Breadcrumbs): Copy text function (#1003)
  fix(statics): handle 404 errors for static files (#1006)
  refactor: Rename 'exclude_missing_annotation' argument for WeakLabels.annotation (#1005)
  docs: update video for spacy ner tutorial (#1000)
  fix(#977) Remove redirection when accessing login (#996)
  feat(#951): new uncovered_by_rules records filter (#991)
  feat(#735): add warning when agent but no prediction/annotation is provided (#987)
  fix(#800): limit number of metadata fields (#993)
  docs: improve annotate records section in web app reference (#985)
  fix(#844) Keep header layout when errors occurred in dataset view (#992)
  fix(#974): display the dropdown in the last record of the scroll (#986)
  refactor: compute common aggregations one by one (#990)
  feat(#953): add additional metrics to `LabelModel.score` method (#979)
  refactor(rules): using labeling rules management with vuex store (#878)
  feat(#955): add default for `rules` in WeakLabels (#976)
  ...
@frascuchon frascuchon removed this from Done in Release Jan 31, 2022
frascuchon pushed a commit that referenced this pull request Feb 2, 2022
* feat: load rules of dataset by default

* test: add tests

* test: fix tests

fix(#1010): fix WeakLabels when not providing rules (#1011)

* fix: bugfix when no rules but a ds is provided

* test: add test

* test: fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[WeakLabels] Load rules from dataset, when no rules are provided
2 participants