Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(search): compute common aggregations one by one #990

Merged
merged 1 commit into from Jan 18, 2022

Conversation

frascuchon
Copy link
Member

See #800

Computing aggregations one at time we reduce situations where search.max_buckets is reached.

Also we should include some limits to number of metadata fields.

@frascuchon frascuchon changed the title refactor: compute common aggregations one by one fix(search): compute common aggregations one by one Jan 17, 2022
@frascuchon frascuchon added this to In progress in Release via automation Jan 17, 2022
@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #990 (4503da8) into master (c40af4f) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #990      +/-   ##
==========================================
- Coverage   95.51%   95.48%   -0.03%     
==========================================
  Files         109      109              
  Lines        4212     4231      +19     
==========================================
+ Hits         4023     4040      +17     
- Misses        189      191       +2     
Flag Coverage Δ
pytest 95.48% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/rubrix/server/tasks/commons/dao/dao.py 97.27% <100.00%> (+0.10%) ⬆️
src/rubrix/server/commons/es_wrapper.py 92.79% <0.00%> (-1.81%) ⬇️
...ubrix/labeling/text_classification/label_models.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c40af4f...4503da8. Read the comment docs.

Release automation moved this from In progress to Reviewer approved Jan 18, 2022
@frascuchon frascuchon merged commit 46f2ce2 into master Jan 18, 2022
Release automation moved this from Reviewer approved to Done Jan 18, 2022
@frascuchon frascuchon deleted the bugfixes/prevent-search.max_buckets-limits branch January 18, 2022 10:18
@frascuchon frascuchon removed this from Done in Release Jan 18, 2022
frascuchon added a commit that referenced this pull request Jan 19, 2022
@frascuchon frascuchon added this to In progress in Release via automation Jan 20, 2022
@frascuchon frascuchon moved this from In progress to Release Ready in Release Jan 20, 2022
@frascuchon frascuchon moved this from Release Ready to Closed in Release Jan 20, 2022
dvsrepo added a commit that referenced this pull request Jan 25, 2022
* 'master' of https://github.com/recognai/rubrix: (28 commits)
  chore(#994): simplify server start (#1014)
  refactor(#945): elasticsearch index configuration per task (#1018)
  docs(#980): Add majorityvote example to weak supervision guide (#1004)
  fix(#1015): manage emojis in Token Classification records (#1016)
  fix(#1010): fix WeakLabels when not providing rules (#1011)
  fix(Breadcrumbs): Copy text function (#1003)
  fix(statics): handle 404 errors for static files (#1006)
  refactor: Rename 'exclude_missing_annotation' argument for WeakLabels.annotation (#1005)
  docs: update video for spacy ner tutorial (#1000)
  fix(#977) Remove redirection when accessing login (#996)
  feat(#951): new uncovered_by_rules records filter (#991)
  feat(#735): add warning when agent but no prediction/annotation is provided (#987)
  fix(#800): limit number of metadata fields (#993)
  docs: improve annotate records section in web app reference (#985)
  fix(#844) Keep header layout when errors occurred in dataset view (#992)
  fix(#974): display the dropdown in the last record of the scroll (#986)
  refactor: compute common aggregations one by one (#990)
  feat(#953): add additional metrics to `LabelModel.score` method (#979)
  refactor(rules): using labeling rules management with vuex store (#878)
  feat(#955): add default for `rules` in WeakLabels (#976)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Release
Approved Release QA
Development

Successfully merging this pull request may close these issues.

[Search] search.max_buckets configuration could affect to search results
2 participants