Improve timeouts and exception handling #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps with debugging underlying issues
This is 2x the other timeouts because I don't want to change the current http timeout behavior. This overall timeout is only a safety measure for when the other timeouts fail us
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the cause to exceptions when catching/throwing errors.
Sets okhttp's callTimeout to ensure that requests are interrupted if they take too long.
Setting callTimeout() to 2x the actual timeout in an attempt to be careful about not impacting existing http/socket timeout behavior. And to only interrupt if it's taken an unreasonable length of time. This is also the ratio that okhttp uses in their examples