Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing documentation for unsupported combination in RandomSplitter #119

Closed
aleSuglia opened this issue Nov 16, 2016 · 3 comments
Closed
Assignees
Labels
Milestone

Comments

@aleSuglia
Copy link
Member

aleSuglia commented Nov 16, 2016

Hello,

using the RandomSplitter I have verified that there is a combination actually not supported (why?) which is not documented. I think that can be useful for users to be aware of this behaviour. In fact, in this case the resulting splits are completely empty and isn't displayed any error message.

See this for reference: https://github.com/recommenders/rival/blob/master/rival-split/src/main/java/net/recommenders/rival/split/splitter/RandomSplitter.java#L99

Cheers,
Alessandro

@abellogin abellogin added the bug label Nov 20, 2016
@abellogin
Copy link
Member

Thank you for noticing.

Indeed, it is a problem since there is no warning displayed.

Thanks again.
Alejandro

@abellogin abellogin added this to the 0.3 milestone Nov 20, 2016
@abellogin abellogin self-assigned this Nov 20, 2016
@aleSuglia
Copy link
Member Author

If you want I have implemented a simple fix in my fork. Here there is the related commit: aleSuglia@e7d347f

@alansaid
Copy link
Member

@aleSuglia please do a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants