Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom behaviour to DataModelUtils.saveModel #120

Closed
aleSuglia opened this issue Nov 16, 2016 · 3 comments
Closed

Add custom behaviour to DataModelUtils.saveModel #120

aleSuglia opened this issue Nov 16, 2016 · 3 comments
Assignees
Milestone

Comments

@aleSuglia
Copy link
Member

Hello,

using the saveModel method of the DataModelUtils it is not possible to specify a field delimiter that is used to write the lines on the file.

In order to be consistent with the loading procedure (implemented by SimpleParser), the method that can be used to save the model should allow users to specify the field delimiter. Do you think that it is an appropriate request?

P.S.
Why do you insert a "-1" as an additional column? Is it required?

Best,
Alessandro

@abellogin abellogin self-assigned this Nov 20, 2016
@abellogin
Copy link
Member

Good point!
DMU should receive a field delimiter in both methods.

The "-1" is added to have the same field generated with a DataModel or a TemporalDataModel.

Best,
Alejandro

@abellogin abellogin added this to the 0.3 milestone Nov 20, 2016
@aleSuglia
Copy link
Member Author

I have implemented a fix for this issue in my fork. Here there is the related commit: aleSuglia@e9f996f

@alansaid
Copy link
Member

@aleSuglia perfect! Please do a pull request an we'll merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants