-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Question] Maven install command #122
Comments
Hi Alessandro, @alansaid has more experience with maven than me, but I think that command would not work because it tries to use the last released version of the library. I am not sure which method should be suggested in the README file... Any comments, @alansaid ? Thank you for the concern, Alessandro. Best, |
I just tried running
|
Thank you for your answer @alansaid. What I mean is that the Travis checker ignores JavaDoc errors whereas using In my opinion this procedure can be clarified in the README in order to let contributors avoid annoying documentation problems and may be aligned with the Travis checker which validates only the submitted code. What do you think about that? I hope that it is clear now what I mean :) Best, |
I think that the idea behind this is to not have incorrect JavaDocs checked in, and you would not check in a broken build. |
Ok I understood your point. Thank you anyway for your help! Closing. |
Hi there,
I experienced some problems while I was writing my pull-request to the main repository. In the https://github.com/recommenders/rival/blob/master/README.md is suggested to use
mvn install
to correctly install the library. Unfortunately, due to missing references to methods in JavaDoc and not commented parameters, it is not possible to correctly install the library.In my opinion, it is appropriate to change the command to the one used by the Travis checker. What do you think about that? Is there a prefereed way in order to completely check if the source code is sound?
Thank you for your answer.
Best,
Alessandro
The text was updated successfully, but these errors were encountered: