Added a part in the vignette customize_plot to show individual cases #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkamvar
reviewed
Oct 11, 2018
vignettes/customize_plot.Rmd
Outdated
|
|
||
| plot(i.small) + | ||
| theme(panel.background = element_rect(fill = "white")) + | ||
| geom_hline(yintercept = c(1:max(i.small$counts)), color = "white") + |
There was a problem hiding this comment.
Please change this to something like:
geom_hline(yintercept = seq(max(get_counts(i.small))), color = "white") +It's best to avoid 1:n style iterations because that could result in accidental reverse sequences.
zkamvar
reviewed
Oct 11, 2018
vignettes/customize_plot.Rmd
Outdated
| plot(i.small) + | ||
| theme(panel.background = element_rect(fill = "white")) + | ||
| geom_hline(yintercept = c(1:max(i.small$counts)), color = "white") + | ||
| geom_vline(xintercept = c(min(i.small$dates):max(i.small$dates)), color = "white") |
There was a problem hiding this comment.
Please change this to:
geom_vline(xintercept = get_dates(i.small), color = "white") +
|
Hi Jakob! Thank you for the contribution. This looks great. I've suggested a couple of changes to style to make the code more robust. Let me know what you think. |
zkamvar
added a commit
that referenced
this pull request
Oct 30, 2018
This is a bit of an extension of #68 by @jakobschumacher to give an option to the user to add episquares to the plot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developed during Recon Workshop in Sofia