Remove RemoveUnusedVariableAssignRector, as could be breaking code in…

… order of excution and hard to do reliable (#3793) * Remove RemoveUnusedVariableAssignRector, as could be breaking code in order of excution and hard to do reliable * [ci-review] Rector Rectify --------- Co-authored-by: GitHub Action <actions@github.com>
rectorphp · May 11, 2023 · 074b178 · 074b178
1 parent c63dd46
commit 074b178
Show file tree

Hide file tree

Showing 16 changed files with 59 additions and 387 deletions.
diff --git a/build/target-repository/docs/rector_rules_overview.md b/build/target-repository/docs/rector_rules_overview.md
@@ -1,12 +1,12 @@
-# 413 Rules Overview
+# 412 Rules Overview
 
 <br>
 
 ## Categories
 
 - [Arguments](#arguments) (6)
 
-- [CodeQuality](#codequality) (77)
+- [CodeQuality](#codequality) (76)
 
 - [CodingStyle](#codingstyle) (37)
 
@@ -1612,26 +1612,6 @@ Change switch with only 1 check to if
 
 <br>
 
-### SplitListAssignToSeparateLineRector
-
-Splits `[$a, $b] = [5, 10]` scalar assign to standalone lines
-
-- class: [`Rector\CodeQuality\Rector\Assign\SplitListAssignToSeparateLineRector`](../rules/CodeQuality/Rector/Assign/SplitListAssignToSeparateLineRector.php)
-
-```diff
- final class SomeClass
- {
-     public function run(): void
-     {
--        [$a, $b] = [1, 2];
-+        $a = 1;
-+        $b = 2;
-     }
- }
-```
-
-<br>
-
 ### StrlenZeroToIdenticalEmptyStringRector
 
 Changes strlen comparison to 0 to direct empty string compare

diff --git a/config/set/code-quality.php b/config/set/code-quality.php
@@ -4,7 +4,6 @@
 
 use Rector\CodeQuality\Rector\Array_\CallableThisArrayToAnonymousFunctionRector;
 use Rector\CodeQuality\Rector\Assign\CombinedAssignRector;
-use Rector\CodeQuality\Rector\Assign\SplitListAssignToSeparateLineRector;
 use Rector\CodeQuality\Rector\BooleanAnd\SimplifyEmptyArrayCheckRector;
 use Rector\CodeQuality\Rector\BooleanNot\ReplaceMultipleBooleanNotRector;
 use Rector\CodeQuality\Rector\BooleanNot\SimplifyDeMorganBinaryRector;
@@ -170,7 +169,6 @@
         ForeachItemsAssignToEmptyArrayToAssignRector::class,
         InlineIfToExplicitIfRector::class,
         ArrayKeysAndInArrayToArrayKeyExistsRector::class,
-        SplitListAssignToSeparateLineRector::class,
         UnusedForeachValueToArrayKeysRector::class,
         CommonNotEqualRector::class,
         SetTypeToCastRector::class,

diff --git a/...sts/CodeQuality/Rector/Assign/SplitListAssignToSeparateLineRector/Fixture/fixture.php.inc b/...sts/CodeQuality/Rector/Assign/SplitListAssignToSeparateLineRector/Fixture/fixture.php.inc
diff --git a/.../CodeQuality/Rector/Assign/SplitListAssignToSeparateLineRector/Fixture/not_scalar.php.inc b/.../CodeQuality/Rector/Assign/SplitListAssignToSeparateLineRector/Fixture/not_scalar.php.inc
diff --git a/...ity/Rector/Assign/SplitListAssignToSeparateLineRector/Fixture/skip_split_of_array.php.inc b/...ity/Rector/Assign/SplitListAssignToSeparateLineRector/Fixture/skip_split_of_array.php.inc
diff --git a/...s/CodeQuality/Rector/Assign/SplitListAssignToSeparateLineRector/Fixture/skip_swap.php.inc b/...s/CodeQuality/Rector/Assign/SplitListAssignToSeparateLineRector/Fixture/skip_swap.php.inc
diff --git a/...lity/Rector/Assign/SplitListAssignToSeparateLineRector/Fixture/with_list_function.php.inc b/...lity/Rector/Assign/SplitListAssignToSeparateLineRector/Fixture/with_list_function.php.inc
diff --git a/...or/Assign/SplitListAssignToSeparateLineRector/SplitListAssignToSeparateLineRectorTest.php b/...or/Assign/SplitListAssignToSeparateLineRector/SplitListAssignToSeparateLineRectorTest.php
diff --git a/.../CodeQuality/Rector/Assign/SplitListAssignToSeparateLineRector/config/configured_rule.php b/.../CodeQuality/Rector/Assign/SplitListAssignToSeparateLineRector/config/configured_rule.php
diff --git a/rules/CodeQuality/Rector/Assign/SplitListAssignToSeparateLineRector.php b/rules/CodeQuality/Rector/Assign/SplitListAssignToSeparateLineRector.php
diff --git a/rules/DeadCode/Rector/Assign/RemoveUnusedVariableAssignRector.php b/rules/DeadCode/Rector/Assign/RemoveUnusedVariableAssignRector.php
@@ -165,7 +165,8 @@ private function shouldSkip(Assign $assign): bool
 
     private function isUsed(Assign $assign, Variable $variable, Scope $scope): bool
     {
-        $isUsedPrev = $scope->hasVariableType((string) $this->getName($variable))->yes();
+        $isUsedPrev = $scope->hasVariableType((string) $this->getName($variable))
+            ->yes();
 
         if ($isUsedPrev) {
             return true;
@@ -239,7 +240,8 @@ private function refactorUsedVariable(Assign $assign, Scope $scope): null|Expr
         if (! $if instanceof If_) {
             if (
                 $assign->var instanceof Variable &&
-                ! $scope->hasVariableType((string) $this->getName($assign->var))->yes() &&
+                ! $scope->hasVariableType((string) $this->getName($assign->var))
+                    ->yes() &&
                 ! $this->exprUsedInNextNodeAnalyzer->isUsed($assign->var)) {
                 return $this->cleanCastedExpr($assign->expr);
             }