Refactor from PARENT_NODE in EncapsedStringsToSprintfRector (#3960)

rectorphp · May 25, 2023 · 18ac565 · 18ac565
1 parent fc1fabe
commit 18ac565
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 32 deletions.
diff --git a/packages/PostRector/Rector/ClassRenamingPostRector.php b/packages/PostRector/Rector/ClassRenamingPostRector.php
@@ -4,8 +4,8 @@
 
 namespace Rector\PostRector\Rector;
 
-use PhpParser\Node\Stmt;
 use PhpParser\Node;
+use PhpParser\Node\Stmt;
 use PhpParser\Node\Stmt\Namespace_;
 use PHPStan\Analyser\Scope;
 use Rector\CodingStyle\Application\UseImportsRemover;

diff --git a/...e/Rector/Encapsed/EncapsedStringsToSprintfRector/Fixture/skip_get_text_underscore.php.inc b/...e/Rector/Encapsed/EncapsedStringsToSprintfRector/Fixture/skip_get_text_underscore.php.inc
diff --git a/rules/CodeQuality/Rector/Foreach_/ForeachItemsAssignToEmptyArrayToAssignRector.php b/rules/CodeQuality/Rector/Foreach_/ForeachItemsAssignToEmptyArrayToAssignRector.php
@@ -4,11 +4,11 @@
 
 namespace Rector\CodeQuality\Rector\Foreach_;
 
-use PhpParser\Node\Stmt;
 use PhpParser\Node;
 use PhpParser\Node\Expr;
 use PhpParser\Node\Expr\Assign;
 use PhpParser\Node\Expr\Variable;
+use PhpParser\Node\Stmt;
 use PhpParser\Node\Stmt\Expression;
 use PhpParser\Node\Stmt\Foreach_;
 use PHPStan\Analyser\Scope;

diff --git a/rules/CodingStyle/Rector/Encapsed/EncapsedStringsToSprintfRector.php b/rules/CodingStyle/Rector/Encapsed/EncapsedStringsToSprintfRector.php
@@ -97,24 +97,6 @@ public function refactor(Node $node): ?Node
 
     private function shouldSkip(Encapsed $encapsed): bool
     {
-        $parentNode = $encapsed->getAttribute(AttributeKey::PARENT_NODE);
-
-        if ($parentNode instanceof Arg) {
-            $node = $parentNode->getAttribute(AttributeKey::PARENT_NODE);
-
-            if ($node instanceof FuncCall && $this->isNames($node, [
-                '_',
-                'dcgettext',
-                'dcngettext',
-                'dgettext',
-                'dngettext',
-                'gettext',
-                'ngettext',
-            ])) {
-                return true;
-            }
-        }
-
         return $encapsed->hasAttribute(AttributeKey::DOC_LABEL);
     }