[DX] Remove *AnnotationIncorrectNullableRector rules as works with un…

…reliable docblocks and can have 2 solutions (#4719)

build/target-repository/docs/rector_rules_overview.md

@@ -1,4 +1,4 @@
-# 360 Rules Overview
+# 357 Rules Overview
 
 <br>
 
@@ -54,7 +54,7 @@
 
 - [Transform](#transform) (22)
 
-- [TypeDeclaration](#typedeclaration) (44)
+- [TypeDeclaration](#typedeclaration) (41)
 
 - [Visibility](#visibility) (3)
 
@@ -7701,30 +7701,6 @@ Change numeric return type based on strict returns type operations
 
 <br>
 
-### ParamAnnotationIncorrectNullableRector
-
-Add or remove null type from `@param` phpdoc typehint based on php parameter type declaration
-
-- class: [`Rector\TypeDeclaration\Rector\ClassMethod\ParamAnnotationIncorrectNullableRector`](../rules/TypeDeclaration/Rector/ClassMethod/ParamAnnotationIncorrectNullableRector.php)
-
-```diff
- final class SomeClass
- {
-     /**
--     * @param \DateTime[] $dateTimes
-+     * @param \DateTime[]|null $dateTimes
-      */
-     public function setDateTimes(?array $dateTimes): self
-     {
-         $this->dateTimes = $dateTimes;
-
-         return $this;
-     }
- }
-```
-
-<br>
-
 ### ParamTypeByMethodCallTypeRector
 
 Change param type based on passed method call type
@@ -7829,28 +7805,6 @@ Add property type based on strict setter and getter method
 
 <br>
 
-### ReturnAnnotationIncorrectNullableRector
-
-Add or remove null type from `@return` phpdoc typehint based on php return type declaration
-
-- class: [`Rector\TypeDeclaration\Rector\ClassMethod\ReturnAnnotationIncorrectNullableRector`](../rules/TypeDeclaration/Rector/ClassMethod/ReturnAnnotationIncorrectNullableRector.php)
-
-```diff
- final class SomeClass
- {
-     /**
--     * @return \DateTime[]
-+     * @return \DateTime[]|null
-      */
-     public function getDateTimes(): ?array
-     {
-         return $this->dateTimes;
-     }
- }
-```
-
-<br>
-
 ### ReturnNeverTypeRector
 
 Add "never" return-type for methods that never return anything
@@ -8288,25 +8242,6 @@ Add strict typed property based on `setUp()` strict typed assigns in TestCase
 
 <br>
 
-### VarAnnotationIncorrectNullableRector
-
-Add or remove null type from `@var` phpdoc typehint based on php property type declaration
-
-- class: [`Rector\TypeDeclaration\Rector\Property\VarAnnotationIncorrectNullableRector`](../rules/TypeDeclaration/Rector/Property/VarAnnotationIncorrectNullableRector.php)
-
-```diff
- final class SomeClass
- {
-     /**
--     * @var DateTime[]
-+     * @var DateTime[]|null
-      */
-     private ?array $dateTimes;
- }
-```
-
-<br>
-
 ### WhileNullableToInstanceofRector
 
 Change while null compare to strict instanceof check

config/set/type-declaration.php

@@ -13,10 +13,8 @@
 use Rector\TypeDeclaration\Rector\ClassMethod\AddVoidReturnTypeWhereNoReturnRector;
 use Rector\TypeDeclaration\Rector\ClassMethod\BoolReturnTypeFromStrictScalarReturnsRector;
 use Rector\TypeDeclaration\Rector\ClassMethod\NumericReturnTypeFromStrictScalarReturnsRector;
-use Rector\TypeDeclaration\Rector\ClassMethod\ParamAnnotationIncorrectNullableRector;
 use Rector\TypeDeclaration\Rector\ClassMethod\ParamTypeByMethodCallTypeRector;
 use Rector\TypeDeclaration\Rector\ClassMethod\ParamTypeByParentCallTypeRector;
-use Rector\TypeDeclaration\Rector\ClassMethod\ReturnAnnotationIncorrectNullableRector;
 use Rector\TypeDeclaration\Rector\ClassMethod\ReturnNeverTypeRector;
 use Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromReturnDirectArrayRector;
 use Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromReturnNewRector;
@@ -40,16 +38,12 @@
 use Rector\TypeDeclaration\Rector\Property\TypedPropertyFromStrictConstructorRector;
 use Rector\TypeDeclaration\Rector\Property\TypedPropertyFromStrictGetterMethodReturnTypeRector;
 use Rector\TypeDeclaration\Rector\Property\TypedPropertyFromStrictSetUpRector;
-use Rector\TypeDeclaration\Rector\Property\VarAnnotationIncorrectNullableRector;
 
 return static function (RectorConfig $rectorConfig): void {
     $rectorConfig->rules([
         AddArrowFunctionReturnTypeRector::class,
         ParamTypeByMethodCallTypeRector::class,
         TypedPropertyFromAssignsRector::class,
-        ReturnAnnotationIncorrectNullableRector::class,
-        VarAnnotationIncorrectNullableRector::class,
-        ParamAnnotationIncorrectNullableRector::class,
         AddReturnTypeDeclarationBasedOnParentClassMethodRector::class,
         ReturnTypeFromStrictTypedPropertyRector::class,
         TypedPropertyFromStrictConstructorRector::class,