[DX] Remove PackageBuilder classes (#2886)

src/DependencyInjection/CompilerPass/AutowireRectorCompilerPass.php

@@ -0,0 +1,25 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Core\DependencyInjection\CompilerPass;
+
+use Rector\Core\Contract\Rector\RectorInterface;
+use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
+use Symfony\Component\DependencyInjection\ContainerBuilder;
+
+final class AutowireRectorCompilerPass implements CompilerPassInterface
+{
+    public function process(ContainerBuilder $containerBuilder): void
+    {
+        $definitions = $containerBuilder->getDefinitions();
+
+        foreach ($definitions as $definition) {
+            if (! is_a((string) $definition->getClass(), RectorInterface::class, true)) {
+                continue;
+            }
+
+            $definition->setAutowired(true);
+        }
+    }
+}

src/Kernel/RectorKernel.php

@@ -5,8 +5,8 @@
 namespace Rector\Core\Kernel;
 
 use Rector\Core\Config\Loader\ConfigureCallMergingLoaderFactory;
-use Rector\Core\Contract\Rector\RectorInterface;
 use Rector\Core\DependencyInjection\Collector\ConfigureCallValuesCollector;
+use Rector\Core\DependencyInjection\CompilerPass\AutowireRectorCompilerPass;
 use Rector\Core\DependencyInjection\CompilerPass\MakeRectorsPublicCompilerPass;
 use Rector\Core\DependencyInjection\CompilerPass\MergeImportedRectorConfigureCallValuesCompilerPass;
 use Rector\Core\DependencyInjection\CompilerPass\RemoveSkippedRectorsCompilerPass;
@@ -15,7 +15,6 @@
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\ContainerInterface;
 use Symplify\AutowireArrayParameter\DependencyInjection\CompilerPass\AutowireArrayParameterCompilerPass;
-use Symplify\PackageBuilder\DependencyInjection\CompilerPass\AutowireInterfacesCompilerPass;
 use Symplify\PackageBuilder\ValueObject\ConsoleColorDiffConfig;
 
 final class RectorKernel
@@ -81,7 +80,7 @@ private function createCompilerPasses(): array
             new RemoveSkippedRectorsCompilerPass(),
 
             // autowire Rectors by default (mainly for tests)
-            new AutowireInterfacesCompilerPass([RectorInterface::class]),
+            new AutowireRectorCompilerPass(),
             new MakeRectorsPublicCompilerPass(),
 
             // add all merged arguments of Rector services

tests/Configuration/ValueObjectInliner/ConfigFactoryNestedTest.php

@@ -5,24 +5,27 @@
 namespace Rector\Core\Tests\Configuration\ValueObjectInliner;
 
 use PHPStan\Type\UnionType;
+use PHPUnit\Framework\TestCase;
+use Rector\Core\Kernel\RectorKernel;
 use Rector\Core\Tests\Configuration\ValueObjectInliner\Source\ServiceWithValueObject;
-use Rector\Core\Tests\Configuration\ValueObjectInliner\Source\ValueObjectInlinerTestKernel;
-use Symplify\PackageBuilder\Testing\AbstractKernelTestCase;
 
-final class ConfigFactoryNestedTest extends AbstractKernelTestCase
+final class ConfigFactoryNestedTest extends TestCase
 {
+    private ServiceWithValueObject $serviceWithValueObject;
+
     protected function setUp(): void
     {
-        $this->bootKernelWithConfigs(ValueObjectInlinerTestKernel::class, [
-            __DIR__ . '/config/config_with_nested_union_type_value_objects.php',
-        ]);
+        $rectorKernel = new RectorKernel();
+        $containerBuilder = $rectorKernel->createFromConfigs(
+            [__DIR__ . '/config/config_with_nested_union_type_value_objects.php']
+        );
+
+        $this->serviceWithValueObject = $containerBuilder->get(ServiceWithValueObject::class);
     }
 
     public function testInlineValueObjectFunction(): void
     {
-        $serviceWithValueObject = $this->getService(ServiceWithValueObject::class);
-        $withType = $serviceWithValueObject->getWithType();
-
+        $withType = $this->serviceWithValueObject->getWithType();
         $this->assertInstanceOf(UnionType::class, $withType->getType());
     }
 }

tests/Configuration/ValueObjectInliner/ConfigFactoryTest.php

@@ -6,33 +6,34 @@
 
 use PHPStan\Type\IntegerType;
 use PHPStan\Type\StringType;
+use PHPUnit\Framework\TestCase;
+use Rector\Core\Kernel\RectorKernel;
 use Rector\Core\Tests\Configuration\ValueObjectInliner\Source\ServiceWithValueObject;
-use Rector\Core\Tests\Configuration\ValueObjectInliner\Source\ValueObjectInlinerTestKernel;
-use Symplify\PackageBuilder\Testing\AbstractKernelTestCase;
 
-final class ConfigFactoryTest extends AbstractKernelTestCase
+final class ConfigFactoryTest extends TestCase
 {
+    private ServiceWithValueObject $serviceWithValueObject;
+
     protected function setUp(): void
     {
-        $this->bootKernelWithConfigs(ValueObjectInlinerTestKernel::class, [
-            __DIR__ . '/config/config_with_nested_value_objects.php',
-        ]);
+        $rectorKernel = new RectorKernel();
+        $containerBuilder = $rectorKernel->createFromConfigs(
+            [__DIR__ . '/config/config_with_nested_value_objects.php']
+        );
+
+        $this->serviceWithValueObject = $containerBuilder->get(ServiceWithValueObject::class);
     }
 
     public function testInlineValueObjectFunction(): void
     {
-        $serviceWithValueObject = $this->getService(ServiceWithValueObject::class);
-        $withType = $serviceWithValueObject->getWithType();
+        $withType = $this->serviceWithValueObject->getWithType();
 
         $this->assertInstanceOf(IntegerType::class, $withType->getType());
     }
 
     public function testInlineValueObjectsFunction(): void
     {
-        /** @var ServiceWithValueObject $serviceWithValueObject */
-        $serviceWithValueObject = $this->getService(ServiceWithValueObject::class);
-
-        $withTypes = $serviceWithValueObject->getWithTypes();
+        $withTypes = $this->serviceWithValueObject->getWithTypes();
         $this->assertCount(1, $withTypes);
 
         $singleWithType = $withTypes[0];

tests/Configuration/ValueObjectInliner/config/config_with_nested_value_objects.php

@@ -13,6 +13,7 @@
 
 return static function (RectorConfig $rectorConfig): void {
     $services = $rectorConfig->services();
+
     $services->defaults()
         ->public()
         ->autowire()