comlexity

rectorphp · Oct 27, 2021 · 7b848a7 · 7b848a7
1 parent 3bda987
commit 7b848a7
Showing 1 changed file with 16 additions and 7 deletions.
diff --git a/rules/Php73/Rector/FuncCall/JsonThrowOnErrorRector.php b/rules/Php73/Rector/FuncCall/JsonThrowOnErrorRector.php
@@ -97,13 +97,7 @@ private function shouldSkip(FuncCall $funcCall): bool
             }
         }
 
-        $firstArg = $funcCall->args[0];
-        $value = $this->valueResolver->getValue($firstArg->value);
-        if (is_string($value)) {
-            return true;
-        }
-
-        if (is_array($value)) {
+        if ($this->isFirstValueStringOrArray($funcCall)) {
             return true;
         }
 
@@ -151,4 +145,19 @@ private function createConstFetch(string $name): ConstFetch
     {
         return new ConstFetch(new Name($name));
     }
+
+    private function isFirstValueStringOrArray(FuncCall $funcCall): bool
+    {
+        if (! isset($funcCall->args[0])) {
+            return false;
+        }
+
+        $firstArg = $funcCall->args[0];
+        $value = $this->valueResolver->getValue($firstArg->value);
+        if (is_string($value)) {
+            return true;
+        }
+
+        return is_array($value);
+    }
 }