[PHP 8.0] Deprecate old UnionTypesRector that is dangerously moving d…

…ocblocks, use type declaration rules instead (#3846)

Co-authored-by: GitHub Action <actions@github.com>

config/set/php80.php

@@ -3,7 +3,6 @@
 declare(strict_types=1);
 
 use Rector\Arguments\Rector\ClassMethod\ArgumentAdderRector;
-
 use Rector\Arguments\Rector\FuncCall\FunctionArgumentDefaultValueReplacerRector;
 use Rector\Arguments\ValueObject\ArgumentAdder;
 use Rector\Arguments\ValueObject\ReplaceFuncCallArgumentDefaultValue;
@@ -21,7 +20,6 @@
 use Rector\Php80\Rector\FuncCall\Php8ResourceReturnToObjectRector;
 use Rector\Php80\Rector\FuncCall\TokenGetAllToObjectRector;
 use Rector\Php80\Rector\FunctionLike\MixedTypeRector;
-use Rector\Php80\Rector\FunctionLike\UnionTypesRector;
 use Rector\Php80\Rector\Identical\StrEndsWithRector;
 use Rector\Php80\Rector\Identical\StrStartsWithRector;
 use Rector\Php80\Rector\NotIdentical\StrContainsRector;
@@ -32,8 +30,6 @@
 use Rector\Transform\ValueObject\StaticCallToFuncCall;
 
 return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->rule(UnionTypesRector::class);
-
     $rectorConfig->rule(StrContainsRector::class);
     $rectorConfig->rule(StrStartsWithRector::class);
     $rectorConfig->rule(StrEndsWithRector::class);

packages/VendorLocker/NodeVendorLocker/ClassMethodParamVendorLockResolver.php

@@ -21,25 +21,6 @@ public function __construct(
     ) {
     }
 
-    /**
-     * Includes non-vendor classes
-     */
-    public function isSoftLocked(ClassMethod $classMethod): bool
-    {
-        if ($this->isVendorLocked($classMethod)) {
-            return true;
-        }
-
-        $classReflection = $this->reflectionResolver->resolveClassReflection($classMethod);
-        if (! $classReflection instanceof ClassReflection) {
-            return false;
-        }
-
-        /** @var string $methodName */
-        $methodName = $this->nodeNameResolver->getName($classMethod);
-        return $this->hasClassMethodLockMatchingFileName($classReflection, $methodName, '');
-    }
-
     public function isVendorLocked(ClassMethod $classMethod): bool
     {
         if ($classMethod->isMagic()) {

phpstan.neon

@@ -794,3 +794,6 @@ parameters:
         # make autoload of php-parser in rector first
         - '#but class PhpParser\\Node\\Stmt\\Expression is not generic#'
         - '#Parameter \#3 \$assign of method Rector\\CodeQuality\\Rector\\FunctionLike\\SimplifyUselessVariableRector\:\:processSimplifyUselessVariable\(\) expects PhpParser\\Node\\Expr\\Assign\|PhpParser\\Node\\Expr\\AssignOp, PhpParser\\Node\\Expr given#'
+
+        # deprecated
+        - '#Register "Rector\\Php80\\Rector\\FunctionLike\\UnionTypesRector" service to "php80\.php" config set#'