[CodingStyle] Remove AddFalseDefaultToBoolPropertyRector, as works wi…

…th unrelaible docblocks (#3856)
rectorphp · May 15, 2023 · f5d809c · f5d809c
1 parent 95b1789
commit f5d809c
Show file tree

Hide file tree

Showing 11 changed files with 2 additions and 249 deletions.
diff --git a/build/target-repository/docs/rector_rules_overview.md b/build/target-repository/docs/rector_rules_overview.md
@@ -1,4 +1,4 @@
-# 406 Rules Overview
+# 405 Rules Overview
 
 <br>
 
@@ -8,7 +8,7 @@
 
 - [CodeQuality](#codequality) (76)
 
-- [CodingStyle](#codingstyle) (35)
+- [CodingStyle](#codingstyle) (34)
 
 - [Compatibility](#compatibility) (1)
 
@@ -1865,25 +1865,6 @@ Adds array default value to property to prevent foreach over null error
 
 <br>
 
-### AddFalseDefaultToBoolPropertyRector
-
-Add false default to bool properties, to prevent null compare errors
-
-- class: [`Rector\CodingStyle\Rector\Property\AddFalseDefaultToBoolPropertyRector`](../rules/CodingStyle/Rector/Property/AddFalseDefaultToBoolPropertyRector.php)
-
-```diff
- class SomeClass
- {
-     /**
-      * @var bool
-      */
--    private $isDisabled;
-+    private $isDisabled = false;
- }
-```
-
-<br>
-
 ### BinarySwitchToIfElseRector
 
 Changes switch with 2 options to if-else

diff --git a/config/set/coding-style.php b/config/set/coding-style.php
@@ -25,7 +25,6 @@
 use Rector\CodingStyle\Rector\If_\NullableCompareToNullRector;
 use Rector\CodingStyle\Rector\Plus\UseIncrementAssignRector;
 use Rector\CodingStyle\Rector\PostInc\PostIncDecToPreIncDecRector;
-use Rector\CodingStyle\Rector\Property\AddFalseDefaultToBoolPropertyRector;
 use Rector\CodingStyle\Rector\Property\SplitGroupedPropertiesRector;
 use Rector\CodingStyle\Rector\Stmt\NewlineAfterStatementRector;
 use Rector\CodingStyle\Rector\String_\SymplifyQuoteEscapeRector;
@@ -64,7 +63,6 @@
         WrapEncapsedVariableInCurlyBracesRector::class,
         NewlineBeforeNewAssignSetRector::class,
         AddArrayDefaultToArrayPropertyRector::class,
-        AddFalseDefaultToBoolPropertyRector::class,
         MakeInheritedMethodVisibilitySameAsParentRector::class,
         CallUserFuncArrayToVariadicRector::class,
         VersionCompareFuncCallToConstantRector::class,

diff --git a/.../Property/AddFalseDefaultToBoolPropertyRector/AddFalseDefaultToBoolPropertyRectorTest.php b/.../Property/AddFalseDefaultToBoolPropertyRector/AddFalseDefaultToBoolPropertyRectorTest.php
diff --git a/...s/CodingStyle/Rector/Property/AddFalseDefaultToBoolPropertyRector/Fixture/fixture.php.inc b/...s/CodingStyle/Rector/Property/AddFalseDefaultToBoolPropertyRector/Fixture/fixture.php.inc
diff --git a/...r/Property/AddFalseDefaultToBoolPropertyRector/Fixture/skip_assigned_in_construct.php.inc b/...r/Property/AddFalseDefaultToBoolPropertyRector/Fixture/skip_assigned_in_construct.php.inc
diff --git a/.../Property/AddFalseDefaultToBoolPropertyRector/Fixture/skip_assigned_in_construct2.php.inc b/.../Property/AddFalseDefaultToBoolPropertyRector/Fixture/skip_assigned_in_construct2.php.inc
diff --git a/...ingStyle/Rector/Property/AddFalseDefaultToBoolPropertyRector/Fixture/skip_default.php.inc b/...ingStyle/Rector/Property/AddFalseDefaultToBoolPropertyRector/Fixture/skip_default.php.inc
diff --git a/...dingStyle/Rector/Property/AddFalseDefaultToBoolPropertyRector/Fixture/skip_string.php.inc b/...dingStyle/Rector/Property/AddFalseDefaultToBoolPropertyRector/Fixture/skip_string.php.inc
diff --git a/...odingStyle/Rector/Property/AddFalseDefaultToBoolPropertyRector/config/configured_rule.php b/...odingStyle/Rector/Property/AddFalseDefaultToBoolPropertyRector/config/configured_rule.php
diff --git a/rules/CodingStyle/Rector/Property/AddFalseDefaultToBoolPropertyRector.php b/rules/CodingStyle/Rector/Property/AddFalseDefaultToBoolPropertyRector.php
diff --git a/rules/DeadCode/Rector/ClassMethod/RemoveUnusedPrivateMethodRector.php b/rules/DeadCode/Rector/ClassMethod/RemoveUnusedPrivateMethodRector.php
@@ -11,7 +11,6 @@
 use PhpParser\Node\Stmt\ClassMethod;
 use PHPStan\Analyser\Scope;
 use PHPStan\Reflection\ClassReflection;
-use Rector\Core\Rector\AbstractRector;
 use Rector\Core\Rector\AbstractScopeAwareRector;
 use Rector\Core\Reflection\ReflectionResolver;
 use Rector\Core\ValueObject\MethodName;