New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PostRector] Improve UseNodesToAddCollector #1151

Merged

TomasVotruba merged 4 commits into main from imporve-use-nodes-to-add-collector

Nov 5, 2021

Member

samsonasik commented Nov 5, 2021 •

edited

Loading

use existing $shortName instead of re-call $fullyQualifiedObjectType->getShortName() in the loop.
move $fullyQualifiedObjectType->getShortNameLowered() to outside loop on ClassLikeNameClassNameImportSkipVoter
early compare to [] before check ->getShortNameLowered()

samsonasik and others added 4 commits

November 5, 2021 15:13


          [PostRector] Improve UseNodesToAddCollector

6052ea7


          move $fullyQualifiedObjectType->getShortNameLowered() to outside loop…

c4b2bc7

… on ClassLikeNameClassNameImportSkipVoter


          [ci-review] Rector Rectify

52940ea


          early compare to [] before check ->getShortNameLowered()

b77ed29

Member Author

samsonasik commented Nov 5, 2021

All checks have passed 🎉 @TomasVotruba it is ready for review.

TomasVotruba approved these changes

View reviewed changes

TomasVotruba merged commit 9b68637 into main

TomasVotruba deleted the imporve-use-nodes-to-add-collector branch

November 5, 2021 10:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet