Fix $this/self docblock compare removed on on-final class, as it can refer to child this type #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
changed the title
TomasVotruba
changed the title
simPod
added a commit
to simPod/rector-src
that referenced
this pull request
Jan 13, 2022
… it can refer to child this type (rectorphp#1246)" This reverts commit a2c2979
simPod
added a commit
to simPod/rector-src
that referenced
this pull request
Jan 14, 2022
… it can refer to child this type (rectorphp#1246)" This reverts commit a2c2979
simPod
added a commit
to simPod/rector-src
that referenced
this pull request
Jan 16, 2022
… it can refer to child this type (rectorphp#1246)" This reverts commit a2c2979
simPod
added a commit
to simPod/rector-src
that referenced
this pull request
Jan 17, 2022
… it can refer to child this type (rectorphp#1246)" This reverts commit a2c2979
samsonasik
pushed a commit
that referenced
this pull request
Jan 17, 2022
…it can refer to child this type (#1246) (#1669) * Revert Fix $this/self docblock compare removed on on-final class, as it can refer to child this type (#1246) This reverts commit a2c2979 * Fix handling of $this return type in UnionTypes rule `$this` refers to the exact object identity, not just the same type. Therefore, its valid and should not be removed @see https://wiki.php.net/rfc/this_return_type for more context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.