Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Privatization] Skip property with attributes in ChangeReadOnlyPropertyWithDefaultValueToConstantRector #1695

Closed
wants to merge 2 commits into from
Closed

[Privatization] Skip property with attributes in ChangeReadOnlyPropertyWithDefaultValueToConstantRector #1695

wants to merge 2 commits into from

Conversation

TomasVotruba
Copy link
Member

  • Do not run ChangeReadOnlyPropertyWithDefaultValueToConstantRector on properties with attributes
  • fix attributes to attrGroups

@TomasVotruba TomasVotruba changed the title skip attr [Privatization] Skip property with attributes in ChangeReadOnlyPropertyWithDefaultValueToConstantRector Jan 18, 2022
@TomasVotruba TomasVotruba mentioned this pull request Jan 18, 2022
Merged
@TomasVotruba
Copy link
Member Author

Merged in #1694

@TomasVotruba TomasVotruba deleted the skip-attr branch January 18, 2022 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomasVotruba @simPod