-
-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add failing test fixture for AnnotationToAttributeRector #225
Conversation
@stephanvierkant I've rebased your fixture and fixed incorrect namespace possition and it is passing ✔️ Thank you for the PR 👍 |
This rector still doesn't work properly. It replaces -/**
- * @UniqueEntity(
- * fields={"parent", "code"},
- * errorPath="code",
- * message="Already exists!",
- * ignoreNull=false,
- * groups={"default", "update"}
- * )
- */
#[Table('Foo')]
-#[Entity]
+#[Entity]
+#[\Doctrine\ORM\Mapping\Entity(fields: ['parent', 'code'], errorPath: 'code', message: 'Already exists!', ignoreNull: false, groups: ['default', 'update'])]
class Foo
-{}
+{} (same demo link) |
@stephanvierkant could you try |
I'm using the demo site. Or is it not running on dev-main? |
demo site is not running latest dev-main, demo site is running latest release. The check of latest release is per-3 days, see: |
Tried on dev-main. Now - /**
- * @Gedmo\SortablePosition
- */
#[Column('position', type: 'integer')]
+ #[\Doctrine\ORM\Mapping\Table]
protected int $position = 0; |
@stephanvierkant please create failing fixture for that, thank you. |
Based on https://getrector.org/demo/4c7348a5-8a07-4f85-aa4d-e462f672dae8