Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Fix bootstrap stubs load on PHP 7.2 when vendor/ excluded via skip() #2394

Merged
merged 8 commits into from
May 31, 2022

Conversation

samsonasik
Copy link
Member

@TomasVotruba this is to fix issue that only happen in PHP 7.2, which can make error:

"Child process error: PHP Fatal error:  Class 'ReflectionUnionType' not found

while working on PHP 7.3 and PHP 7.4. Reproduced repository :

https://github.com/Micr0mega/rector-issue-7196/runs/6651988104?check_suite_focus=true#step:5:10

/cc @Micr0mega

Fixes rectorphp/rector#7196

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba
Copy link
Member

Thanks 👍

Please add a reproducer test, so we have it covered for future.

@samsonasik samsonasik force-pushed the fix-php72-exclude-vendor-load-stub branch 2 times, most recently from 0aa263e to 9e99442 Compare May 30, 2022 13:00
@samsonasik
Copy link
Member Author

I've added e2e test for rector/rector for run under php 7.2 9e99442

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I think it is ready.

@samsonasik samsonasik force-pushed the fix-php72-exclude-vendor-load-stub branch from 30179db to 2da394e Compare May 30, 2022 14:09
@samsonasik
Copy link
Member Author

rebased.

@TomasVotruba TomasVotruba merged commit 5640d51 into main May 31, 2022
@TomasVotruba TomasVotruba deleted the fix-php72-exclude-vendor-load-stub branch May 31, 2022 12:38
@TomasVotruba
Copy link
Member

TomasVotruba commented May 31, 2022

Thank you 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fatal error: Class 'ReflectionUnionType' not found with PHP 7.2
3 participants