Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHPStan] Clean up ignore errors in phpstan.neon #240

Merged
merged 2 commits into from
Jun 17, 2021

Conversation

samsonasik
Copy link
Member

No description provided.

@samsonasik samsonasik enabled auto-merge (squash) June 17, 2021 14:38
@samsonasik
Copy link
Member Author

samsonasik commented Jun 17, 2021

There are strange PHPStan error in CI https://github.com/rectorphp/rector-src/pull/240/checks?check_run_id=2850022814#step:5:35

------------------------------------------------------------------------
  packages/StaticTypeMapper/PhpDocParser/UnionTypeMapper.php:17
 ------------------------------------------------------------------------
  - '#Class with base "UnionTypeMapper" name is already used in "Rector\\PHPStanStaticTypeMapper\\TypeMapper\\UnionTypeMapper", "Rector\\StaticTypeMapper\\PhpDocParser\\UnionTypeMapper"\. Use unique name to make classes easy to recognize#'
 ------------------------------------------------------------------------
 ------------------------------------------------------------------------
  packages/StaticTypeMapper/StaticTypeMapper.php:31
 ------------------------------------------------------------------------
  - '#Class with base "StaticTypeMapper" name is already used in "Rector\\PHPStanStaticTypeMapper\\TypeMapper\\StaticTypeMapper", "Rector\\StaticTypeMapper\\StaticTypeMapper"\. Use unique name to make classes easy to recognize#'
 ------------------------------------------------------------------------

It is working fine in my local dev, even with composer update, and clear phpstan cache.

@samsonasik
Copy link
Member Author

Fixed 🎉

@samsonasik samsonasik merged commit a41a5ba into main Jun 17, 2021
@samsonasik samsonasik deleted the clean-up-ignore-errors branch June 17, 2021 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant