[CodeQuality] Deprecate NarrowUnionTypeDocRector as focused on docblocks, and moving to type declarations #3848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
force-pushed
the
tv-narrow-doc-types
branch
from
1974401
to
e3b52cb
Compare
…cks, and moving to type declarations
TomasVotruba
force-pushed
the
tv-narrow-doc-types
branch
from
e3b52cb
to
ca170f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Rector 0.15 we've added safe type declarations in property, param and return types. This required splitting many rules to smaller strict ones.
I've just noticed we've forgot to handle the union types as well, this PR is fixing it 👍
Follow up to #3846
See https://getrector.com/blog/new-in-rector-015-complete-safe-and-known-type-declarations