[Traverser] Refactor BetterNodeFinder::findFirstNext() to remove next attribute usage #3879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
force-pushed
the
refactor-find-first-next
branch
from
b237f29
to
f205c56
Compare
samsonasik
force-pushed
the
refactor-find-first-next
branch
from
cce4f12
to
702cef5
Compare
samsonasik
commented
May 17, 2023
|
It seems cause error infinite loop, I will check more :) |
samsonasik
commented
May 18, 2023
Comment on lines
+554
to
+556
| // todo: use +1 key once all next node attribute reference and NodeConnectingVisitor removed | ||
| // left with add SlimNodeConnectingVisitor for only lookup parent | ||
| return $node->getAttribute(AttributeKey::NEXT_NODE); |
There was a problem hiding this comment.
@TomasVotruba @staabm I tried many things, and it keep crashing/infinite loop without this one left over.
I think this part can be removed once we have all next/prev node attribute removed and removed the NodeConnectingVisitor, left with add SlimNodeConnectingVisitor for only lookup parent
|
All checks have passed 🎉 @TomasVotruba I think it is good enough for now 👍 |
|
@TomasVotruba I am merging it for now, in separate PR, i will try improve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@TomasVotruba @staabm this is continue of PR:
to remove next attribute usage on
BetterNodeFinder::findFirstNext()Ref rectorphp/rector#7940