New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHPStanStaticTypeMapper] Clean up tweak false and bool check on UnionTypeMapper #5209

Merged

samsonasik merged 1 commit into main from union-manual-false

Oct 28, 2023

Member

samsonasik commented Oct 28, 2023

It seems was used when at:

[TypeDeclaration] Refactor UnionTypeMapper::narrowBoolType() to allow bool|int|false converted to bool|int #3685

which we still use docblock, we now use more native type check instead. This PR remove it.


          [PHPStanStaticTypeMapper] Clean up tweak false and bool check on Unio…

dddd29b

…nTypeMapper

samsonasik requested a review from TomasVotruba as a code owner

October 28, 2023 12:37

Member Author

samsonasik commented Oct 28, 2023

All checks have passed 🎉 @TomasVotruba I am merging it ;)

samsonasik merged commit 6f33010 into main

41 checks passed

samsonasik deleted the union-manual-false branch

October 28, 2023 12:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet