[DeadCode] Fix remove dead stmt Rector #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
TomasVotruba
commented
May 17, 2021
•
TomasVotruba
commented
- Fixes [TASK] Add failing test #64
- Fixes SetList::DEAD_CODE with SetList::SAFE_07 causes PHP Fatal error rector#6420
TomasVotruba
changed the title
| @@ -58,6 +58,10 @@ public function refactor(Node $node) | |||
| return $this->removeNodeAndKeepComments($node); | |||
| } | |||
|
|
|||
| if ($livingCode === [$node->expr]) { | |||
There was a problem hiding this comment.
That´s it? I don´t get it.
There was a problem hiding this comment.
It means that the code that should be kept alive (not removed) is the same as current node.
Nothing to be removed, just return null
There was a problem hiding this comment.
This rule would deserve more refactoring to improve readability and logic behind it, but we have more important things to do 👍
TomasVotruba
force-pushed
the
issue-6420-failing-test
branch
2 times, most recently
from
82c4e5b
to
e504331
Compare
TomasVotruba
force-pushed
the
issue-6420-failing-test
branch
from
b254f67
to
57098c3
Compare
TomasVotruba
force-pushed
the
issue-6420-failing-test
branch
from
25df75b
to
e6453a2
Compare
samsonasik
pushed a commit
that referenced
this pull request
May 18, 2021
Co-authored-by: Sebastian Schreiber <me@schreibersebastian.de> Co-authored-by: kaizen-ci <info@kaizen-ci.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.