Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test to ConsoleExecuteReturnIntRector for a not command class #2197

Merged
merged 1 commit into from
Oct 25, 2019
Merged

Add test to ConsoleExecuteReturnIntRector for a not command class #2197

merged 1 commit into from
Oct 25, 2019

Conversation

franmomu
Copy link
Contributor

When using ConsoleExecuteReturnIntRector on a class with an execute method that not extends from Command it adds the return 0 and adds : int.

@TomasVotruba
Copy link
Member

Thanks!

@TomasVotruba TomasVotruba merged commit c86d9fc into rectorphp:master Oct 25, 2019
@TomasVotruba
Copy link
Member

@keulinho Could you look at it?

@franmomu franmomu deleted the command_test branch October 25, 2019 10:04
@keulinho
Copy link
Contributor

@TomasVotruba yep will provide an fix

keulinho added a commit to keulinho/rector that referenced this pull request Oct 25, 2019
@keulinho
Fix ConsoleExecuteReturnIntRector for non console commands
cb3ef10 
Fixes: rectorphp#2197
@TomasVotruba
Copy link
Member

Thank you

TomasVotruba added a commit that referenced this pull request Apr 29, 2022
@TomasVotruba
Updated Rector to commit 6063b59
639bf5c 
rectorphp/rector-src@6063b59 [Php74] Refactor MakePropertyTypedGuard to check directly on ClassReflection instead of lookup parent to get class (#2197)
TomasVotruba added a commit that referenced this pull request Apr 29, 2022
@TomasVotruba
Updated Rector to commit 6063b59
934d528 
rectorphp/rector-src@6063b59 [Php74] Refactor MakePropertyTypedGuard to check directly on ClassReflection instead of lookup parent to get class (#2197)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@franmomu @TomasVotruba @keulinho