-
Notifications
You must be signed in to change notification settings - Fork 0
Port Cathedral color theme into RecursionLab site #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,17 +4,17 @@ | |
|
||
%tab-focus { | ||
/* Default*/ | ||
outline: thin dotted #f89406; | ||
outline: thin dotted $theme-color; | ||
/* Webkit*/ | ||
outline: 5px auto #f89406; | ||
outline: 5px auto $theme-color; | ||
outline-offset: -2px; | ||
} | ||
|
||
p>code, a>code, li>code, figcaption>code, td>code { | ||
padding-top: 0.1rem; | ||
padding-bottom: 0.1rem; | ||
background: #f2f3f3; | ||
border: 1px solid #b2b2b2; | ||
background: $code-background-color; | ||
border: 1px solid $border-color; | ||
border-radius: 2px; | ||
font-size: 0.8em; | ||
} | ||
|
@@ -24,27 +24,25 @@ div.highlighter-rouge .highlight, figure.highlight .highlight { | |
} | ||
|
||
/* #mastheadbackground { | ||
height: 155px; | ||
margin-bottom: -175px; | ||
background-color: #F2F3F3; | ||
height: 155px; | ||
margin-bottom: -175px; | ||
background-color: $code-background-color; | ||
}*/ | ||
|
||
.highligher-rouge { | ||
font-size: .8em; | ||
} | ||
|
||
table td { | ||
border-bottom: solid 2px #e6e6e6; | ||
} | ||
table td { border-bottom: solid 2px mix(#fff, $border-color, 60%); } | ||
|
||
.button-dark { | ||
display: inline-block; | ||
padding: 12px 24px; | ||
border-radius: 6px; | ||
border: 2px solid #a33025; | ||
border: 2px solid hsl(var(--destructive)); | ||
font-weight: bold; | ||
background: #F2F3F3; | ||
color: #a33025; | ||
background: hsl(var(--muted)); | ||
color: hsl(var(--destructive)); | ||
} | ||
|
||
@mixin clearfix { | ||
|
@@ -166,11 +164,11 @@ blockquote:before { | |
position: absolute; | ||
left: -0.2em; | ||
top: -0.2em; | ||
color: #7a7a7a; | ||
color: mix(#fff, $text-color, 50%); | ||
} | ||
|
||
blockquote cite { | ||
color: #999999; | ||
color: mix(#fff, $text-color, 60%); | ||
Comment on lines
+167
to
+171
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. suggestion: Mixing #fff with $text-color for blockquote elements may not adapt well to dark mode. Consider using theme variables or adjusting the mix ratio to ensure sufficient contrast and readability in dark mode. Suggested implementation:
To fully implement this, you should:
:root {
--blockquote-cite-color: #666; /* Light mode */
}
[data-theme="dark"] {
--blockquote-cite-color: #bbb; /* Dark mode */
}
|
||
font-size: 0.9em; | ||
display: block; | ||
margin-top: 5px; | ||
|
@@ -210,9 +208,9 @@ tt, code, kbd, samp, pre { | |
|
||
pre { | ||
overflow-x: auto; | ||
border-left: solid 0 #52d841; | ||
color: #4fff38; | ||
background: #404040; | ||
border-left: solid 0 $border-color; | ||
color: $text-color; | ||
background: $code-background-color; | ||
line-height: 1.4; | ||
font-size: .8em; | ||
margin: 0 0 1.7em; | ||
|
@@ -333,10 +331,7 @@ figcaption { | |
-webkit-transition: $global-transition; | ||
transition: $global-transition; | ||
|
||
&:hover { | ||
color: #000; | ||
border-bottom-color: #000; | ||
} | ||
&:hover { color: $link-color-hover; border-bottom-color: $link-color-hover; } | ||
} | ||
} | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,13 +33,13 @@ body { margin: 0; } | |
/* Selected elements */ | ||
|
||
::-moz-selection { | ||
color: #fff; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. issue: Selection color and background may be confusing if $background-color is light. Swapping the selection colors or choosing a more distinct highlight will improve legibility, especially with light backgrounds and dark text. |
||
background: #000; | ||
color: $background-color; | ||
background: $text-color; | ||
} | ||
|
||
::selection { | ||
color: #fff; | ||
background: #000; | ||
color: $background-color; | ||
background: $text-color; | ||
} | ||
|
||
/* Display HTML5 elements in IE6-9 and FF3 */ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Mixing #fff with $border-color for table borders may reduce contrast in dark themes.
Consider using a variable or conditional logic to maintain adequate border contrast in both light and dark themes for accessibility.
Suggested implementation:
If your theme switching uses CSS custom properties (variables) or a different mechanism, you should adapt the variable assignment accordingly. For example, you might use
var(--table-border-color)
and set that property in your theme root or body selector. If you use SCSS maps or functions for theme management, update those instead.