api rename change: Template -> Render #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to name the objects in play with this lib, I was running into mental roadblocks with the current setup. You need two objects in play here: one to store the configuration from the user and another to be the scope that the template source is evaluated against. I had originally thought I would use `Template` for the config and _something_ else for the scope. But as I tried to name the something I realized the naming was off. I think `Template` should be the scope your source file evals against. It's called a "template file" after all. So here I'm thinking the config object should be called a `Render`. A render builds and renders a template in the correct format. The naming seems to flow better with the action and other names involved. This does the trivial rename of `Template` to `Render`.
|
@jcredding since we briefly discussed this yesterday, going to go ahead and merge. |
kellyredding
added a commit
that referenced
this pull request
Apr 21, 2014
api rename change: Template -> Render
kellyredding
added a commit
that referenced
this pull request
Jun 4, 2014
first alpha release: * setup benchmarking against RABL #1 * Readme with usage/notes details on template rendering #2 * basic template class with source file and locals #3 * api rename change: Template -> Render #4 * first pass at Template class with `node` and `map` implemmentations #5 * have templates evaluate given source files #6 * apply locals to template scope as reader methods #7 * Source object for rendering templates #8 * updated bench scripts to bench against Nm #9 * `render` and `partial` template and source methods #10 /cc @jcredding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to name the objects in play with this lib, I was running
into mental roadblocks with the current setup. You need two objects
in play here: one to store the configuration from the user and another
to be the scope that the template source is evaluated against.
I had originally thought I would use
Templatefor the config andsomething else for the scope. But as I tried to name the something
I realized the naming was off. I think
Templateshould be thescope your source file evals against. It's called a "template file"
after all.
So here I'm thinking the config object should be called a
Render.A render builds and renders a template in the correct format. The
naming seems to flow better with the action and other names involved.
This does the trivial rename of
TemplatetoRender.@jcredding ready for review.