updated bench scripts to bench against Nm #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reworks the bench helpers to namespace them all under `NmBench` and commonizes the non engine specific aspects (like the `Logger`). Then using this common stuff, it adds scripts for benching against Nm. There are two benches for Nm: one where the source is built once and then rendered against many times, and one where the source is re-built each time. I did this to make sure I was comparing fairly against RABL. The results are stored in `bench/results`. Nm, even with rebuilding its source unnecessarily each run, outperforms RABL in all cases.
|
@kellyredding - Cool, results are awesome. All the benchmarking logic looks good 💥 |
kellyredding
added a commit
that referenced
this pull request
Apr 28, 2014
updated bench scripts to bench against Nm
kellyredding
added a commit
that referenced
this pull request
Jun 4, 2014
first alpha release: * setup benchmarking against RABL #1 * Readme with usage/notes details on template rendering #2 * basic template class with source file and locals #3 * api rename change: Template -> Render #4 * first pass at Template class with `node` and `map` implemmentations #5 * have templates evaluate given source files #6 * apply locals to template scope as reader methods #7 * Source object for rendering templates #8 * updated bench scripts to bench against Nm #9 * `render` and `partial` template and source methods #10 /cc @jcredding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reworks the bench helpers to namespace them all under
NmBenchand commonizes the non engine specific aspects (like the
Logger).Then using this common stuff, it adds scripts for benching against
Nm.
There are two benches for Nm: one where the source is built once
and then rendered against many times, and one where the source is
re-built each time. I did this to make sure I was comparing fairly
against RABL.
The results are stored in
bench/results. Nm, even with rebuildingits source unnecessarily each run, outperforms RABL in all cases.
@jcredding the diff is rugged due to moving everything under the
NmBenchmodule - sorry. The bench results are for rendering a 100-slide slideshow N number of times. Nm takes around 25% of the time RABL does to run.