Add loid created timestamp #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 17, 2022 11:07
dm464
force-pushed
the
denisse--add-loid-created-ms
branch
from
c8eed9f to
7aea8ca
Compare
mrlevitas
reviewed
Aug 17, 2022
reddit_decider/__init__.py
Outdated
| "id": self._user_id, | ||
| "logged_in": self._logged_in, | ||
| "cookie_created_timestamp": self._cookie_created_timestamp, | ||
| "loid_created_timstamp": self._loid_created_timestamp, |
There was a problem hiding this comment.
this function is used to dump data for v2 event exposures, and the v2 event schema doesn't have this field on user so we can eliminate it here
mrlevitas
reviewed
Aug 17, 2022
reddit_decider/__init__.py
Outdated
| "device_id": self._device_id, | ||
| "origin_service": self._origin_service, | ||
| "cookie_created_timestamp": self._cookie_created_timestamp, | ||
| "loid_created_timestamp": self._loid_created_timestamp, |
There was a problem hiding this comment.
similar here, there's no top level field in v2 event schema for loid (or any field for loid in v2 events) so let's get rid of it here as well
dm464
force-pushed
the
denisse--add-loid-created-ms
branch
from
16ab2c7 to
0c6e089
Compare
|
let's tag a new release after we merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💸 TL;DR
This PR passes
loid_created_msfrom the edge context to the decider asloid_created_timestampThis corresponding PR adds
loid_created_timestampinto the decider context.