-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate IRC colours to in-game #13
Comments
I could be unclear on exactly what the request is, but IRC->Cube color codes already work, albeit not entirely as they should. This line shows that all it does is find any EOT escapes ( However, the colors that each number in the color escape sequence represents may not match the ones that Cube uses depending on the IRC client. This is because the IRC protocol does not in itself support color codes and is a feature implemented by the IRC client, thus the color mappings may vary, or not exist at all. Most clients that I know of conform to mIRC color codes. There are two problems with the current implementation:
Regarding the first point, examine the table below. What appears as say, Green in a message sent in IRC would appear as Red in-game, because the color code 3 is Green in IRC, but Red in Cube.
Regarding the second problem, Cube only uses a single character to determine the color in the color escape sequence (not counting the use of brackets), where IRC color codes can use 2 digits. Consider the following message, sent by a user in IRC:
In IRC, it would display: This is because only the This could be fixed by applying the reverse of what |
Well, I've got working code at the moment, just need to make sure it melds well with the rest of the code and I'm not missing any bugs |
- Conforms to mIRC color codes, so most IRC clients should support them correctly. - Normal, white colored Game->IRC text is no longer sent as pure black, but simply with no color code so IRC clients will use their default color. This prevents relayed game text being unreadable in IRC clients with dark backgrounds.
- Conforms to mIRC color codes, so most IRC clients should support them correctly. - Normal, white colored Game->IRC text is no longer sent as pure black, but simply with no color code so IRC clients will use their default color. This prevents relayed game text being unreadable in IRC clients with dark backgrounds.
Fix/Enhance IRC Relay colors. Fixes issue #13
Fixed by #47 |
From: http://redeclipse.net/forum/viewtopic.php?f=9&t=460
Since Red Eclipse already translates in-game colors to IRC colors, as per a var in the servinit.cfg, I would very much like to see the reverse as well. That way, color codes are not shown in irc-to-game output.
The text was updated successfully, but these errors were encountered: